undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

mktag tests: test "hash-object" compatibility

Browse Source 
Change all the successful "mktag" tests to test that "hash-object"
produces the same hash for the input, and that fsck passes for
both.

This tests e.g. that "mktag" doesn't trim its input or otherwise munge
it in a way that "hash-object" doesn't.

Since we're doing an "fsck --strict" here at the end let's incorporate
the creation of the "mytag" name into this test, removing the
special-case at the end of the file.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2021-01-05 20:42:40 +01:00 committed by Junio C Hamano
parent 47c95e77d1
commit ca9a1ed969
1 changed files with 17 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

31
t/t3800-mktag.sh
View File

@ -19,6 +19,19 @@ check_verify_failure () {
'
}
test_expect_mktag_success() {
test_expect_success "$1" '
git hash-object -t tag -w --stdin <tag.sig >expected &&
git fsck --strict &&
git mktag <tag.sig >hash &&
test_cmp expected hash &&
test_when_finished "git update-ref -d refs/tags/mytag $(cat hash)" &&
git update-ref refs/tags/mytag $(cat hash) $(test_oid zero) &&
git fsck --strict
'
}
###########################################################
# first create a commit, so we have a valid object/type
# for the tag.
@ -220,9 +233,7 @@ tagger T A Gger <> 0 +0000
EOF
test_expect_success \
'allow empty tag email' \
'git mktag <tag.sig'
test_expect_mktag_success 'allow empty tag email'
############################################################
# 16. disallow spaces in tag email
@ -347,9 +358,7 @@ tagger T A Gger <tagger@example.com> 1206478233 -0500
this line comes after an extra newline
EOF
test_expect_success 'allow extra newlines at start of body' '
git mktag <tag.sig
'
test_expect_mktag_success 'allow extra newlines at start of body'
cat >tag.sig <<EOF
object $head
@ -359,9 +368,7 @@ tagger T A Gger <tagger@example.com> 1206478233 -0500
EOF
test_expect_success 'require a blank line before an empty body (1)' '
git mktag <tag.sig
'
test_expect_mktag_success 'require a blank line before an empty body (1)'
cat >tag.sig <<EOF
object $head
@ -384,10 +391,6 @@ tagger T A Gger <tagger@example.com> 1206478233 -0500
EOF
test_expect_success 'create valid tag' '
git mktag <tag.sig >hash &&
git update-ref refs/tags/mytag $(cat hash) $(test_oid zero) &&
git fsck --strict
'
test_expect_mktag_success 'create valid tag object'
test_done