undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-blame.el: use mapc instead of mapcar

Browse Source 
Using mapcar here is a waste of memory because the mapped result
is not used.

Noticed by emacs ("Warning: `mapcar' called for effect").

[jn: split from a larger patch, with new description]

Signed-off-by: Rüdiger Sonderfeld <ruediger@c-plusplus.de>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Rüdiger Sonderfeld 2012-06-10 02:38:03 -05:00 committed by Junio C Hamano
parent f174a2583c
commit cbbc935ce0
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/emacs/git-blame.el
View File

@ -304,7 +304,7 @@ See also function `git-blame-mode'."
(defun git-blame-cleanup () (defun git-blame-cleanup ()
"Remove all blame properties" "Remove all blame properties"
(mapcar 'delete-overlay git-blame-overlays) (mapc 'delete-overlay git-blame-overlays)
(setq git-blame-overlays nil) (setq git-blame-overlays nil)
(remove-git-blame-text-properties (point-min) (point-max))) (remove-git-blame-text-properties (point-min) (point-max)))