Merge branch 'ar/clone-honor-umask-at-top'
A handful of files and directories we create had tighter than necessary permission bits when the user wanted to have group writability (e.g. by setting "umask 002"). * ar/clone-honor-umask-at-top: add: create ADD_EDIT.patch with mode 0666 rerere: make rr-cache fanout directory honor umask Restore umasks influence on the permissions of work tree created by clone
This commit is contained in:
commit
cc24a7fbe5
@ -281,7 +281,7 @@ static int edit_patch(int argc, const char **argv, const char *prefix)
|
||||
argc = setup_revisions(argc, argv, &rev, NULL);
|
||||
rev.diffopt.output_format = DIFF_FORMAT_PATCH;
|
||||
DIFF_OPT_SET(&rev.diffopt, IGNORE_DIRTY_SUBMODULES);
|
||||
out = open(file, O_CREAT | O_WRONLY, 0644);
|
||||
out = open(file, O_CREAT | O_WRONLY, 0666);
|
||||
if (out < 0)
|
||||
die (_("Could not open '%s' for writing."), file);
|
||||
rev.diffopt.file = xfdopen(out, "w");
|
||||
|
@ -708,7 +708,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
|
||||
if (safe_create_leading_directories_const(work_tree) < 0)
|
||||
die_errno(_("could not create leading directories of '%s'"),
|
||||
work_tree);
|
||||
if (!dest_exists && mkdir(work_tree, 0755))
|
||||
if (!dest_exists && mkdir(work_tree, 0777))
|
||||
die_errno(_("could not create work tree dir '%s'."),
|
||||
work_tree);
|
||||
set_git_work_tree(work_tree);
|
||||
|
2
rerere.c
2
rerere.c
@ -524,7 +524,7 @@ static int do_plain_rerere(struct string_list *rr, int fd)
|
||||
continue;
|
||||
hex = xstrdup(sha1_to_hex(sha1));
|
||||
string_list_insert(rr, path)->util = hex;
|
||||
if (mkdir(git_path("rr-cache/%s", hex), 0755))
|
||||
if (mkdir_in_gitdir(git_path("rr-cache/%s", hex)))
|
||||
continue;
|
||||
handle_file(path, NULL, rerere_path(hex, "preimage"));
|
||||
fprintf(stderr, "Recorded preimage for '%s'\n", path);
|
||||
|
Loading…
Reference in New Issue
Block a user