undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'mv/unknown'

Browse Source 
* mv/unknown:
  Don't use "<unknown>" for placeholders and suppress printing of empty user formats.
This commit is contained in:
Junio C Hamano 2007-10-03 04:28:24 -07:00
commit cc61ae82ec
6 changed files with 11 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
builtin-rev-list.c
View File

@ -84,6 +84,7 @@ static void show_commit(struct commit *commit)
strbuf_init(&buf, 0); strbuf_init(&buf, 0);
pretty_print_commit(revs.commit_format, commit, pretty_print_commit(revs.commit_format, commit,
&buf, revs.abbrev, NULL, NULL, revs.date_mode); &buf, revs.abbrev, NULL, NULL, revs.date_mode);
if (buf.len)
printf("%s%c", buf.buf, hdr_termination); printf("%s%c", buf.buf, hdr_termination);
strbuf_release(&buf); strbuf_release(&buf);
} }

3
commit.c
View File

@ -876,9 +876,6 @@ void format_commit_message(const struct commit *commit,
} }
if (msg[i]) if (msg[i])
table[IBODY].value = xstrdup(msg + i); table[IBODY].value = xstrdup(msg + i);
for (i = 0; i < ARRAY_SIZE(table); i++)
if (!table[i].value)
interp_set_entry(table, i, "<unknown>");
len = interpolate(sb->buf + sb->len, strbuf_avail(sb), len = interpolate(sb->buf + sb->len, strbuf_avail(sb),
format, table, ARRAY_SIZE(table)); format, table, ARRAY_SIZE(table));

6
interpolate.c
View File

@ -73,8 +73,12 @@ unsigned long interpolate(char *result, unsigned long reslen,
/* Check for valid interpolation. */ /* Check for valid interpolation. */
if (i < ninterps) { if (i < ninterps) {
value = interps[i].value; value = interps[i].value;
valuelen = strlen(value); if (!value) {
src += namelen;
continue;
}
valuelen = strlen(value);
if (newlen + valuelen < reslen) { if (newlen + valuelen < reslen) {
/* Substitute. */ /* Substitute. */
memcpy(dest, value, valuelen); memcpy(dest, value, valuelen);

1
log-tree.c
View File

@ -280,6 +280,7 @@ void show_log(struct rev_info *opt, const char *sep)
if (opt->show_log_size) if (opt->show_log_size)
printf("log size %i\n", (int)msgbuf.len); printf("log size %i\n", (int)msgbuf.len);
if (msgbuf.len)
printf("%s%s%s", msgbuf.buf, extra, sep); printf("%s%s%s", msgbuf.buf, extra, sep);
strbuf_release(&msgbuf); strbuf_release(&msgbuf);
} }

8
t/t6006-rev-list-format.sh
View File

@ -79,9 +79,7 @@ EOF
test_format encoding %e <<'EOF' test_format encoding %e <<'EOF'
commit 131a310eb913d107dd3c09a65d1651175898735d commit 131a310eb913d107dd3c09a65d1651175898735d
<unknown>
commit 86c75cfd708a0e5868dc876ed5b8bb66c80b4873 commit 86c75cfd708a0e5868dc876ed5b8bb66c80b4873
<unknown>
EOF EOF
test_format subject %s <<'EOF' test_format subject %s <<'EOF'
@ -93,9 +91,7 @@ EOF
test_format body %b <<'EOF' test_format body %b <<'EOF'
commit 131a310eb913d107dd3c09a65d1651175898735d commit 131a310eb913d107dd3c09a65d1651175898735d
<unknown>
commit 86c75cfd708a0e5868dc876ed5b8bb66c80b4873 commit 86c75cfd708a0e5868dc876ed5b8bb66c80b4873
<unknown>
EOF EOF
test_format colors %Credfoo%Cgreenbar%Cbluebaz%Cresetxyzzy <<'EOF' test_format colors %Credfoo%Cgreenbar%Cbluebaz%Cresetxyzzy <<'EOF'
@ -121,9 +117,7 @@ test_format complex-encoding %e <<'EOF'
commit f58db70b055c5718631e5c61528b28b12090cdea commit f58db70b055c5718631e5c61528b28b12090cdea
iso8859-1 iso8859-1
commit 131a310eb913d107dd3c09a65d1651175898735d commit 131a310eb913d107dd3c09a65d1651175898735d
<unknown>
commit 86c75cfd708a0e5868dc876ed5b8bb66c80b4873 commit 86c75cfd708a0e5868dc876ed5b8bb66c80b4873
<unknown>
EOF EOF
test_format complex-subject %s <<'EOF' test_format complex-subject %s <<'EOF'
@ -142,9 +136,7 @@ and it will be encoded in iso8859-1. We should therefore
include an iso8859 character: ¡bueno! include an iso8859 character: ¡bueno!
commit 131a310eb913d107dd3c09a65d1651175898735d commit 131a310eb913d107dd3c09a65d1651175898735d
<unknown>
commit 86c75cfd708a0e5868dc876ed5b8bb66c80b4873 commit 86c75cfd708a0e5868dc876ed5b8bb66c80b4873
<unknown>
EOF EOF
test_done test_done

4
t/t7500-commit.sh
View File

@ -81,7 +81,7 @@ test_expect_success 'explicit commit message should override template' '
git add foo && git add foo &&
GIT_EDITOR=../t7500/add-content git commit --template "$TEMPLATE" \ GIT_EDITOR=../t7500/add-content git commit --template "$TEMPLATE" \
-m "command line msg" && -m "command line msg" &&
commit_msg_is "command line msg<unknown>" commit_msg_is "command line msg"
' '
test_expect_success 'commit message from file should override template' ' test_expect_success 'commit message from file should override template' '
@ -90,7 +90,7 @@ test_expect_success 'commit message from file should override template' '
echo "standard input msg" | echo "standard input msg" |
GIT_EDITOR=../t7500/add-content git commit \ GIT_EDITOR=../t7500/add-content git commit \
--template "$TEMPLATE" --file - && --template "$TEMPLATE" --file - &&
commit_msg_is "standard input msg<unknown>" commit_msg_is "standard input msg"
' '
test_done test_done