undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

send-email: don't use Mail::Address, even if available

Browse Source 
Using Mail::Address made sense when we didn't have a proper parser. We
now have a reasonable address parser, and using Mail::Address
_if available_ causes much more trouble than it gives benefits:

* Developers typically test one version, not both.

* Users may not be aware that installing Mail::Address will change the
  behavior. They may complain about the behavior in one case without
  knowing that Mail::Address is involved.

* Having this optional Mail::Address makes it tempting to anwser "please
  install Mail::Address" to users instead of fixing our own code. We've
  reached the stage where bugs in our parser should be fixed, not worked
  around.

Signed-off-by: Matthieu Moy <git@matthieu-moy.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Matthieu Moy 2017-08-23 12:21:02 +02:00 committed by Junio C Hamano
parent cb2922fe4b
commit cc90750677
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
git-send-email.perl
View File

@ -155,7 +155,6 @@ sub format_2822_time {
} }
my $have_email_valid = eval { require Email::Valid; 1 }; my $have_email_valid = eval { require Email::Valid; 1 };
my $have_mail_address = eval { require Mail::Address; 1 };
my $smtp; my $smtp;
my $auth; my $auth;
my $num_sent = 0; my $num_sent = 0;
@ -490,11 +489,7 @@ my ($repoauthor, $repocommitter);
($repocommitter) = Git::ident_person(@repo, 'committer'); ($repocommitter) = Git::ident_person(@repo, 'committer');
sub parse_address_line { sub parse_address_line {
if ($have_mail_address) { return Git::parse_mailboxes($_[0]);
return map { $_->format } Mail::Address->parse($_[0]);
} else {
return Git::parse_mailboxes($_[0]);
}
} }
sub split_addrs { sub split_addrs {