undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refs API: ignore errno in worktree.c's add_head_info()

Browse Source 
The static add_head_info() function is only used indirectly by callers
of get_worktrees(), none of whom care about errno, and even if they
did having the faked-up one from refs_resolve_ref_unsafe() would only
confuse them if they used die_errno() et al. So let's explicitly
ignore it here.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2021-10-16 11:39:18 +02:00 committed by Junio C Hamano
parent ac0986e302
commit ccf3cc1b18
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
worktree.c
View File

@ -28,11 +28,13 @@ static void add_head_info(struct worktree *wt)
{ {
int flags; int flags;
const char *target; const char *target;
int ignore_errno;
target = refs_resolve_ref_unsafe(get_worktree_ref_store(wt), target = refs_werrres_ref_unsafe(get_worktree_ref_store(wt),
"HEAD", "HEAD",
0, 0,
&wt->head_oid, &flags); &wt->head_oid, &flags,
&ignore_errno);
if (!target) if (!target)
return; return;