undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

contrib/examples/git-repack.sh: avoid "test <cond> -a/-o <cond>"

Browse Source 
The construct is error-prone; "test" being built-in in most modern
shells, the reason to avoid "test <cond> && test <cond>" spawning
one extra process by using a single "test <cond> -a <cond>" no
longer exists.

Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Elia Pinto 2014-06-06 07:55:48 -07:00 committed by Junio C Hamano
parent 57b74cdaba
commit cd4de93f2e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/examples/git-repack.sh
View File

@ -76,8 +76,8 @@ case ",$all_into_one," in
existing="$existing $e" existing="$existing $e"
fi fi
done done
if test -n "$existing" -a -n "$unpack_unreachable" -a \ if test -n "$existing" && test -n "$unpack_unreachable" && \
-n "$remove_redundant" test -n "$remove_redundant"
then then
# This may have arbitrary user arguments, so we # This may have arbitrary user arguments, so we
# have to protect it against whitespace splitting # have to protect it against whitespace splitting