undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

contrib/git-svn: fix a copied-tree bug in an overzealous assertion

Browse Source 
I thought passing --stop-on-copy to svn would save us from all
the trouble svn-arch-mirror had with directory (project) copies.
I was wrong, there was one thing I overlooked.

If a tree was moved from /foo/trunk to /bar/foo/trunk with no
other changes in r10, but the last change was done in r5, the
Last Changed Rev (from svn info) in /bar/foo/trunk will still be
r5, even though the copy in the repository didn't exist until
r10.

Now, if we ever detect that the Last Changed Rev isn't what
we're expecting, we'll run svn diff and only croak if there are
differences between them.

Signed-off-by: Eric Wong <normalperson@yhbt.net>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Eric Wong 2006-03-03 13:35:48 -08:00 committed by Junio C Hamano
parent f794c23466
commit ce4c8b24a1
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
contrib/git-svn/git-svn.perl
View File

@ -337,10 +337,17 @@ sub assert_svn_wc_clean {
my ($svn_rev, $treeish) = @_; my ($svn_rev, $treeish) = @_;
croak "$svn_rev is not an integer!\n" unless ($svn_rev =~ /^\d+$/); croak "$svn_rev is not an integer!\n" unless ($svn_rev =~ /^\d+$/);
croak "$treeish is not a sha1!\n" unless ($treeish =~ /^$sha1$/o); croak "$treeish is not a sha1!\n" unless ($treeish =~ /^$sha1$/o);
my $svn_info = svn_info('.'); my $lcr = svn_info('.')->{'Last Changed Rev'};
if ($svn_rev != $svn_info->{'Last Changed Rev'}) { if ($svn_rev != $lcr) {
croak "Expected r$svn_rev, got r", print STDERR "Checking for copy-tree ... ";
$svn_info->{'Last Changed Rev'},"\n"; # use
my @diff = grep(/^Index: /,(safe_qx(qw(svn diff),
"-r$lcr:$svn_rev")));
if (@diff) {
croak "Nope! Expected r$svn_rev, got r$lcr\n";
} else {
print STDERR "OK!\n";
}
} }
my @status = grep(!/^Performing status on external/,(`svn status`)); my @status = grep(!/^Performing status on external/,(`svn status`));
@status = grep(!/^\s*$/,@status); @status = grep(!/^\s*$/,@status);