undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Fix up progress report for off-by-one error

Browse Source 
We used to print the index of the object we unpacked, not how many we
had unpacked.  Which caused slightly confusing progress reports like

	100% (2/3) done

rather than the more obvious "3/3" for 100% ;)
This commit is contained in:
Linus Torvalds 2005-07-10 16:14:22 -07:00
parent 4bc5fbf82e
commit cf219196a8
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
unpack-objects.c
View File

@ -211,7 +211,7 @@ static void unpack_one(unsigned nr, unsigned total)
static unsigned long last_sec; static unsigned long last_sec;
static unsigned last_percent; static unsigned last_percent;
struct timeval now; struct timeval now;
unsigned percentage = ((1+nr) * 100) / total; unsigned percentage = (nr * 100) / total;
gettimeofday(&now, NULL); gettimeofday(&now, NULL);
if (percentage != last_percent || now.tv_sec != last_sec) { if (percentage != last_percent || now.tv_sec != last_sec) {
@ -255,7 +255,7 @@ static void unpack_all(void)
use(sizeof(struct pack_header)); use(sizeof(struct pack_header));
for (i = 0; i < nr_objects; i++) for (i = 0; i < nr_objects; i++)
unpack_one(i, nr_objects); unpack_one(i+1, nr_objects);
if (delta_list) if (delta_list)
die("unresolved deltas left after unpacking"); die("unresolved deltas left after unpacking");
} }