undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

submodule: prevent backslash expantion in submodule names

Browse Source 
When attempting to add a submodule with backslashes in its name 'git
submodule' fails in a funny way.  We can see that some of the
backslashes are expanded resulting in a bogus path:

git -C main submodule add ../sub\\with\\backslash
fatal: repository '/tmp/test/sub\witackslash' does not exist
fatal: clone of '/tmp/test/sub\witackslash' into submodule path

To solve this, convert calls to 'read' to 'read -r' in git-submodule.sh
in order to prevent backslash expantion in submodule names.

Reported-by: Joachim Durchholz <jo@durchholz.org>
Signed-off-by: Brandon Williams <bmwill@google.com>
Reviewed-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Brandon Williams 2017-04-07 10:23:06 -07:00 committed by Junio C Hamano
parent cf11a67975
commit cf9e55f494
2 changed files with 21 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
git-submodule.sh
View File

@ -332,7 +332,7 @@ cmd_foreach()
git submodule--helper list --prefix "$wt_prefix" || git submodule--helper list --prefix "$wt_prefix" ||
echo "#unmatched" $? echo "#unmatched" $?
} | } |
while read mode sha1 stage sm_path while read -r mode sha1 stage sm_path
do do
die_if_unmatched "$mode" "$sha1" die_if_unmatched "$mode" "$sha1"
if test -e "$sm_path"/.git if test -e "$sm_path"/.git
@ -441,7 +441,7 @@ cmd_deinit()
git submodule--helper list --prefix "$wt_prefix" "$@" || git submodule--helper list --prefix "$wt_prefix" "$@" ||
echo "#unmatched" $? echo "#unmatched" $?
} | } |
while read mode sha1 stage sm_path while read -r mode sha1 stage sm_path
do do
die_if_unmatched "$mode" "$sha1" die_if_unmatched "$mode" "$sha1"
name=$(git submodule--helper name "$sm_path") || exit name=$(git submodule--helper name "$sm_path") || exit
@ -605,7 +605,7 @@ cmd_update()
"$@" || echo "#unmatched" $? "$@" || echo "#unmatched" $?
} | { } | {
err= err=
while read mode sha1 stage just_cloned sm_path while read -r mode sha1 stage just_cloned sm_path
do do
die_if_unmatched "$mode" "$sha1" die_if_unmatched "$mode" "$sha1"
@ -847,7 +847,7 @@ cmd_summary() {
# Get modified modules cared by user # Get modified modules cared by user
modules=$(git $diff_cmd $cached --ignore-submodules=dirty --raw $head -- "$@" | modules=$(git $diff_cmd $cached --ignore-submodules=dirty --raw $head -- "$@" |
sane_egrep '^:([0-7]* )?160000' | sane_egrep '^:([0-7]* )?160000' |
while read mod_src mod_dst sha1_src sha1_dst status sm_path while read -r mod_src mod_dst sha1_src sha1_dst status sm_path
do do
# Always show modules deleted or type-changed (blob<->module) # Always show modules deleted or type-changed (blob<->module)
if test "$status" = D || test "$status" = T if test "$status" = D || test "$status" = T
@ -873,7 +873,7 @@ cmd_summary() {
git $diff_cmd $cached --ignore-submodules=dirty --raw $head -- $modules | git $diff_cmd $cached --ignore-submodules=dirty --raw $head -- $modules |
sane_egrep '^:([0-7]* )?160000' | sane_egrep '^:([0-7]* )?160000' |
cut -c2- | cut -c2- |
while read mod_src mod_dst sha1_src sha1_dst status name while read -r mod_src mod_dst sha1_src sha1_dst status name
do do
if test -z "$cached" && if test -z "$cached" &&
test $sha1_dst = 0000000000000000000000000000000000000000 test $sha1_dst = 0000000000000000000000000000000000000000
@ -1020,7 +1020,7 @@ cmd_status()
git submodule--helper list --prefix "$wt_prefix" "$@" || git submodule--helper list --prefix "$wt_prefix" "$@" ||
echo "#unmatched" $? echo "#unmatched" $?
} | } |
while read mode sha1 stage sm_path while read -r mode sha1 stage sm_path
do do
die_if_unmatched "$mode" "$sha1" die_if_unmatched "$mode" "$sha1"
name=$(git submodule--helper name "$sm_path") || exit name=$(git submodule--helper name "$sm_path") || exit
@ -1100,7 +1100,7 @@ cmd_sync()
git submodule--helper list --prefix "$wt_prefix" "$@" || git submodule--helper list --prefix "$wt_prefix" "$@" ||
echo "#unmatched" $? echo "#unmatched" $?
} | } |
while read mode sha1 stage sm_path while read -r mode sha1 stage sm_path
do do
die_if_unmatched "$mode" "$sha1" die_if_unmatched "$mode" "$sha1"

14
t/t7400-submodule-basic.sh
View File

@ -273,6 +273,20 @@ test_expect_success 'submodule add with ./, /.. and // in path' '
test_cmp empty untracked test_cmp empty untracked
' '
test_expect_success 'submodule add with \\ in path' '
test_when_finished "rm -rf parent sub\\with\\backslash" &&
# Initialize a repo with a backslash in its name
git init sub\\with\\backslash &&
touch sub\\with\\backslash/empty.file &&
git -C sub\\with\\backslash add empty.file &&
git -C sub\\with\\backslash commit -m "Added empty.file" &&
# Add that repository as a submodule
git init parent &&
git -C parent submodule add ../sub\\with\\backslash
'
test_expect_success 'submodule add in subdirectory' ' test_expect_success 'submodule add in subdirectory' '
echo "refs/heads/master" >expect && echo "refs/heads/master" >expect &&
>empty && >empty &&