undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fast-export: drop unused parameter from anonymize_commit_message()

Browse Source 
As the comment above the function indicates, we do not bother actually
storing commit messages in our anonymization map. But we still take the
message as a parameter, and just ignore it. Let's stop doing that, which
will make -Wunused-parameter happier.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2023-03-22 13:43:22 -04:00 committed by Junio C Hamano
parent 65c756fff0
commit d051f1718e
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
builtin/fast-export.c
View File

@ -556,7 +556,7 @@ static const char *anonymize_refname(const char *refname)
* We do not even bother to cache commit messages, as they are unlikely * We do not even bother to cache commit messages, as they are unlikely
* to be repeated verbatim, and it is not that interesting when they are. * to be repeated verbatim, and it is not that interesting when they are.
*/ */
static char *anonymize_commit_message(const char *old) static char *anonymize_commit_message(void)
{ {
static int counter; static int counter;
return xstrfmt("subject %d\n\nbody\n", counter++); return xstrfmt("subject %d\n\nbody\n", counter++);
@ -683,7 +683,7 @@ static void handle_commit(struct commit *commit, struct rev_info *rev,
mark_next_object(&commit->object); mark_next_object(&commit->object);
if (anonymize) { if (anonymize) {
reencoded = anonymize_commit_message(message); reencoded = anonymize_commit_message();
} else if (encoding) { } else if (encoding) {
switch(reencode_mode) { switch(reencode_mode) {
case REENCODE_YES: case REENCODE_YES: