undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

remote-mediawiki: limit filenames to legal

Browse Source 
mediawiki pages can have names longer than NAME_MAX (generally 255)
characters, which will fail on checkout. we simply strip out extra
characters, which may mean one page's content will overwrite another
(the last editing winning).

ideally, we would do a more clever system to find unique names, but
that would be more difficult and error prone for a situation that
should rarely happen in the first place.

Signed-off-by: Antoine Beaupré <anarcat@debian.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Antoine Beaupré 2017-10-29 14:15:11 -04:00 committed by Junio C Hamano
parent cb5918aa0d
commit d1a7050f93
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/mw-to-git/Git/Mediawiki.pm
View File

@ -2,6 +2,7 @@ package Git::Mediawiki;
use 5.008;
use strict;
use POSIX;
use Git;
BEGIN {
@ -52,7 +53,7 @@ sub smudge_filename {
$filename =~ s/ /_/g;
# Decode forbidden characters encoded in clean_filename
$filename =~ s/_%_([0-9a-fA-F][0-9a-fA-F])/sprintf('%c', hex($1))/ge;
return $filename;
return substr($filename, 0, NAME_MAX-length('.mw'));
}
sub connect_maybe {