undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'jc/clone-remote-name-leak-fix' into maint

Browse Source 
"git clone --origin X" leaked piece of memory that held value read
from the clone.defaultRemoteName configuration variable, which has
been plugged.
source: <xmqqlevl4ysk.fsf@gitster.g>

* jc/clone-remote-name-leak-fix:
  clone: plug a miniscule leak
This commit is contained in:
Junio C Hamano 2022-06-08 14:27:53 -07:00
commit d2b11e05e0
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
builtin/clone.c
View File

@ -1106,8 +1106,10 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
* apply the remote name provided by --origin only after this second * apply the remote name provided by --origin only after this second
* call to git_config, to ensure it overrides all config-based values. * call to git_config, to ensure it overrides all config-based values.
*/ */
if (option_origin != NULL) if (option_origin != NULL) {
free(remote_name);
remote_name = xstrdup(option_origin); remote_name = xstrdup(option_origin);
}
if (remote_name == NULL) if (remote_name == NULL)
remote_name = xstrdup("origin"); remote_name = xstrdup("origin");