undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ref-filter: die on parse_commit errors

Browse Source 
The tag-contains algorithm quietly returns "does not
contain" when parse_commit() fails. But a parse failure is
an indication that the repository is corrupt. We should die
loudly rather than producing a bogus result.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2017-03-09 08:29:04 -05:00 committed by Junio C Hamano
parent a0262c51d0
commit d344d1cb8a
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ref-filter.c
View File

@ -1523,9 +1523,7 @@ static enum contains_result contains_test(struct commit *candidate,
return CONTAINS_YES; return CONTAINS_YES;
} }
if (parse_commit(candidate) < 0) parse_commit_or_die(candidate);
return CONTAINS_NO;
return CONTAINS_UNKNOWN; return CONTAINS_UNKNOWN;
} }