undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test-bundle-uri: drop unused variables

Browse Source 
Commit 70b9c10373 (bundle-uri client: add helper for testing server,
2022-12-22) added a cmd_ls_remote() function which contains "uploadpack"
and "server_options" variables. Neither of these variables is ever
modified after being initialized, so the code to handle non-NULL and
non-empty values is impossible to reach.

While in theory we might add command-line parsing to set these, let's
drop the dead code for now in the name of cleanliness. It's easy enough
to add it back later if need be.

Noticed by Coverity.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2023-01-06 03:48:23 -05:00 committed by Junio C Hamano
parent 876094ac16
commit d4e241a145
1 changed files with 0 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
t/helper/test-bundle-uri.c
View File

@ -76,8 +76,6 @@ usage:
static int cmd_ls_remote(int argc, const char **argv)
{
const char *uploadpack = NULL;
struct string_list server_options = STRING_LIST_INIT_DUP;
const char *dest;
struct remote *remote;
struct transport *transport;
@ -95,11 +93,6 @@ static int cmd_ls_remote(int argc, const char **argv)
die(_("remote '%s' has no configured URL"), dest);
transport = transport_get(remote, NULL);
if (uploadpack)
transport_set_option(transport, TRANS_OPT_UPLOADPACK, uploadpack);
if (server_options.nr)
transport->server_options = &server_options;
if (transport_get_remote_bundle_uri(transport) < 0) {
error(_("could not get the bundle-uri list"));
status = 1;