undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t5512: allow any protocol version for filtered symref test

Browse Source 
We have a test that checks that ls-remote, when asked only about HEAD,
will report the HEAD symref, and not others. This was marked to always
run with the v0 protocol by b2f73b70b2 (t5512: compensate for v0 only
sending HEAD symrefs, 2019-02-25).

But in v0 this test is doing nothing! For v0, upload-pack only reports
the HEAD symref anyway, so we'd never have any other symref to report.

For v2, it is useful; we learn about all symrefs (and the test repo has
multiple), so this demonstrates that we correctly avoid showing them.

We could perhaps mark this to test explicitly with v2, but since that is
the default these days, it's sufficient to just run ls-remote without
any protocol specification. It still passes if somebody does an explicit
GIT_TEST_PROTOCOL_VERSION=0; it's just testing less.

Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jeff King 2023-04-14 17:25:16 -04:00 committed by Junio C Hamano
parent 20272ee8cf
commit d6747adfa8
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
t/t5512-ls-remote.sh
View File

@ -271,9 +271,7 @@ test_expect_success 'ls-remote with filtered symref (refname)' '
ref: refs/heads/main HEAD ref: refs/heads/main HEAD
$rev HEAD $rev HEAD
EOF EOF
# Protocol v2 supports sending symrefs for refs other than HEAD, so use git ls-remote --symref . HEAD >actual &&
# protocol v0 here.
GIT_TEST_PROTOCOL_VERSION=0 git ls-remote --symref . HEAD >actual &&
test_cmp expect actual test_cmp expect actual
' '