undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'jn/size-t-casted-to-off-t-fix'

Browse Source 
Rewrite code that triggers undefined behaiour warning.

* jn/size-t-casted-to-off-t-fix:
  xsize_t: avoid implementation defined behavior when len < 0
This commit is contained in:
Junio C Hamano 2021-06-10 12:04:23 +09:00
commit d6e35a2644
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
git-compat-util.h
View File

@ -986,11 +986,9 @@ static inline char *xstrdup_or_null(const char *str)
static inline size_t xsize_t(off_t len)
{
size_t size = (size_t) len;
if (len != (off_t) size)
if (len < 0 || (uintmax_t) len > SIZE_MAX)
die("Cannot handle files this big");
return size;
return (size_t) len;
}
__attribute__((format (printf, 3, 4)))