undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-format-patch: do not crash with format.headers without value.

Browse Source 
An incorrect config file can say:

	[format]
		headers

and crash the parsing.

Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Junio C Hamano 2007-01-17 11:13:02 -08:00
parent 03eeaeaea5
commit d7fb91c69d
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
builtin-log.c
View File

@ -202,7 +202,11 @@ static const char *fmt_patch_suffix = ".txt";
static int git_format_config(const char *var, const char *value) static int git_format_config(const char *var, const char *value)
{ {
if (!strcmp(var, "format.headers")) { if (!strcmp(var, "format.headers")) {
int len = strlen(value); int len;
if (!value)
die("format.headers without value");
len = strlen(value);
extra_headers_size += len + 1; extra_headers_size += len + 1;
extra_headers = xrealloc(extra_headers, extra_headers_size); extra_headers = xrealloc(extra_headers, extra_headers_size);
extra_headers[extra_headers_size - len - 1] = 0; extra_headers[extra_headers_size - len - 1] = 0;