t9502: fix &&-chain breakage
This script misses a trivial &&-chain in one of its tests, but it also has a weird reverse: it includes an &&-chain outside of any test_expect block! This "cat" should never fail, but if it did, we would not notice, as it would cause us to skip the follow-on test entirely (which does not appear intentional; there are many later tests which rely on this cat). Let's instead move the setup into its own test_expect_success block, which is the standard practice nowadays. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
aef591a0f9
commit
d8cd32792a
@ -145,9 +145,11 @@ test_expect_success 'forks: not skipped unless "forks" feature enabled' '
|
||||
grep -q ">fork of .*<" gitweb.body
|
||||
'
|
||||
|
||||
cat >>gitweb_config.perl <<\EOF &&
|
||||
$feature{'forks'}{'default'} = [1];
|
||||
EOF
|
||||
test_expect_success 'enable forks feature' '
|
||||
cat >>gitweb_config.perl <<-\EOF
|
||||
$feature{"forks"}{"default"} = [1];
|
||||
EOF
|
||||
'
|
||||
|
||||
test_expect_success 'forks: forks skipped if "forks" feature enabled' '
|
||||
gitweb_run "a=project_list" &&
|
||||
@ -173,7 +175,7 @@ test_expect_success 'forks: can access forked repository' '
|
||||
'
|
||||
|
||||
test_expect_success 'forks: project_index lists all projects (incl. forks)' '
|
||||
cat >expected <<-\EOF
|
||||
cat >expected <<-\EOF &&
|
||||
.git
|
||||
foo.bar.git
|
||||
foo.git
|
||||
|
Loading…
Reference in New Issue
Block a user