undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rev-parse test: use test_must_fail, not "if <command>; then false; fi"

Browse Source 
This way, if rev-parse segfaults then the test will fail instead
of treating it the same way as a controlled failure.

Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Felipe Contreras 2013-09-03 10:06:18 -07:00 committed by Junio C Hamano
parent dfb1dc5c33
commit d8f7681337
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
t/t6101-rev-parse-parents.sh
View File

@ -26,7 +26,7 @@ test_expect_success 'start^0' '
'
test_expect_success 'start^1 not valid' '
if git rev-parse --verify start^1; then false; else :; fi
test_must_fail git rev-parse --verify start^1
'
test_expect_success 'second^1 = second^' '
@ -50,7 +50,7 @@ test_expect_success 'final^1^2 != final^1^1' '
'
test_expect_success 'final^1^3 not valid' '
if git rev-parse --verify final^1^3; then false; else :; fi
test_must_fail git rev-parse --verify final^1^3
'
test_expect_success '--verify start2^1' '