undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t7810: use test_expect_code() instead of hand-rolled comparison

Browse Source 
This test manually checks the exit code of git-grep for a particular
value. In doing so, it intentionally breaks the &&-chain. Modernize the
test by taking advantage of test_expect_code() and a normal &&-chain.

Signed-off-by: Eric Sunshine <sunshine@sunshineco.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Eric Sunshine 2018-07-01 20:23:52 -04:00 committed by Junio C Hamano
parent adc73318fe
commit d964def526
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
t/t7810-grep.sh
View File

@ -845,10 +845,9 @@ test_expect_success 'grep from a subdirectory to search wider area (1)' '
test_expect_success 'grep from a subdirectory to search wider area (2)' ' test_expect_success 'grep from a subdirectory to search wider area (2)' '
mkdir -p s && mkdir -p s &&
( (
cd s || exit 1 cd s &&
( git grep xxyyzz .. >out ; echo $? >status ) test_expect_code 1 git grep xxyyzz .. >out &&
! test -s out && ! test -s out
test 1 = $(cat status)
) )
' '