undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Solaris 5.8 returns ENOTDIR for inappropriate renames.

Browse Source 
The reflog code clears empty directories when rename returns
either EISDIR or ENOTDIR.  Seems to be the only place.

Signed-off-by: Jason Riedy <ejr@cs.berkeley.edu>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Jason Riedy 2007-01-15 17:30:59 -08:00 committed by Junio C Hamano
parent 2aad957a51
commit d9e74d5745
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
refs.c
View File

@ -837,7 +837,12 @@ int rename_ref(const char *oldref, const char *newref, const char *logmsg)
retry: retry:
if (log && rename(git_path("tmp-renamed-log"), git_path("logs/%s", newref))) { if (log && rename(git_path("tmp-renamed-log"), git_path("logs/%s", newref))) {
if (errno==EISDIR) { if (errno==EISDIR || errno==ENOTDIR) {
/*
* rename(a, b) when b is an existing
* directory ought to result in ISDIR, but
* Solaris 5.8 gives ENOTDIR. Sheesh.
*/
if (remove_empty_directories(git_path("logs/%s", newref))) { if (remove_empty_directories(git_path("logs/%s", newref))) {
error("Directory not empty: logs/%s", newref); error("Directory not empty: logs/%s", newref);
goto rollback; goto rollback;