undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

parse-options: drop leading space from '--git-completion-helper' output

Browse Source 
The output of 'git <cmd> --git-completion-helper' always starts with a
space, e.g.:

  $ git config --git-completion-helper
   --global --system --local [...]

This doesn't matter for the completion script, because field splitting
discards that space anyway.

However, later patches in this series will teach parse-options to
handle subcommands, and subcommands will be included in the completion
helper output as well.  This will make the loop printing options (and
subcommands) a tad more complex, so I wanted to test the result.  The
test would have to account for the presence of that leading space,
which bugged my OCD, so let's get rid of it.

Signed-off-by: SZEDER Gábor <szeder.dev@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
SZEDER Gábor 2022-08-19 18:03:59 +02:00 committed by Junio C Hamano
parent a9126b92a2
commit dc9f98832b
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
parse-options.c
View File

@ -620,7 +620,8 @@ static int show_gitcomp(const struct option *opts, int show_all)
suffix = "="; suffix = "=";
if (starts_with(opts->long_name, "no-")) if (starts_with(opts->long_name, "no-"))
nr_noopts++; nr_noopts++;
printf(" --%s%s", opts->long_name, suffix); printf("%s--%s%s", opts == original_opts ? "" : " ",
opts->long_name, suffix);
} }
show_negated_gitcomp(original_opts, show_all, -1); show_negated_gitcomp(original_opts, show_all, -1);
show_negated_gitcomp(original_opts, show_all, nr_noopts); show_negated_gitcomp(original_opts, show_all, nr_noopts);