undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

t4014: remove confusing pipe in check_threading()

Browse Source 
In check_threading(), there was a Git command in the upstream of a pipe.
In order to not lose its status code, it was saved into a file. However,
this may be confusing so rewrite to redirect IO to file. This allows us
to directly use the conventional &&-chain.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Denton Liu 2019-08-27 00:05:12 -04:00 committed by Junio C Hamano
parent 6bd26f58ea
commit dd2b6b6860
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
t/t4014-format-patch.sh
View File

@ -319,7 +319,7 @@ test_expect_success 'reroll count (-v)' '
check_threading () {
expect="$1" &&
shift &&
(git format-patch --stdout "$@"; echo $? >status.out) |
git format-patch --stdout "$@" >patch &&
# Prints everything between the Message-ID and In-Reply-To,
# and replaces all Message-ID-lookalikes by a sequence number
perl -ne '
@ -334,8 +334,7 @@ check_threading () {
print;
}
print "---\n" if /^From /i;
' >actual &&
test 0 = "$(cat status.out)" &&
' <patch >actual &&
test_cmp "$expect" actual
}