undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

connected.c: free the "struct packed_git"

Browse Source 
The "new_pack" we allocate in check_connected() wasn't being
free'd. Let's do that before we return from the function. This has
leaked ever since "new_pack" was added to this function in
c6807a40dc (clone: open a shortcut for connectivity check,
2013-05-26).

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Taylor Blau <me@ttaylorr.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2022-11-08 19:17:47 +01:00 committed by Junio C Hamano
parent f1f4ebf432
commit dd4143e7bf
8 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
connected.c
View File

@ -85,6 +85,7 @@ int check_connected(oid_iterate_fn fn, void *cb_data,
promisor_pack_found: promisor_pack_found:
; ;
} while ((oid = fn(cb_data)) != NULL); } while ((oid = fn(cb_data)) != NULL);
free(new_pack);
return 0; return 0;
} }
@ -118,8 +119,10 @@ no_promisor_pack_found:
else else
rev_list.no_stderr = opt->quiet; rev_list.no_stderr = opt->quiet;
if (start_command(&rev_list)) if (start_command(&rev_list)) {
free(new_pack);
return error(_("Could not run 'git rev-list'")); return error(_("Could not run 'git rev-list'"));
}
sigchain_push(SIGPIPE, SIG_IGN); sigchain_push(SIGPIPE, SIG_IGN);
@ -151,5 +154,6 @@ no_promisor_pack_found:
err = error_errno(_("failed to close rev-list's stdin")); err = error_errno(_("failed to close rev-list's stdin"));
sigchain_pop(SIGPIPE); sigchain_pop(SIGPIPE);
free(new_pack);
return finish_command(&rev_list) || err; return finish_command(&rev_list) || err;
} }

1
t/t3050-subprojects-fetch.sh
View File

@ -2,6 +2,7 @@
test_description='fetching and pushing project with subproject' test_description='fetching and pushing project with subproject'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
test_expect_success setup ' test_expect_success setup '

1
t/t4067-diff-partial-clone.sh
View File

@ -2,6 +2,7 @@
test_description='behavior of diff when reading objects in a partial clone' test_description='behavior of diff when reading objects in a partial clone'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
test_expect_success 'git show batches blobs' ' test_expect_success 'git show batches blobs' '

2
t/t5544-pack-objects-hook.sh
View File

@ -1,6 +1,8 @@
#!/bin/sh #!/bin/sh
test_description='test custom script in place of pack-objects' test_description='test custom script in place of pack-objects'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
test_expect_success 'create some history to fetch' ' test_expect_success 'create some history to fetch' '

1
t/t5610-clone-detached.sh
View File

@ -4,6 +4,7 @@ test_description='test cloning a repository with detached HEAD'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
head_is_detached() { head_is_detached() {

1
t/t5611-clone-config.sh
View File

@ -4,6 +4,7 @@ test_description='tests for git clone -c key=value'
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
test_expect_success 'clone -c sets config in cloned repo' ' test_expect_success 'clone -c sets config in cloned repo' '

1
t/t5614-clone-submodules-shallow.sh
View File

@ -2,6 +2,7 @@
test_description='Test shallow cloning of repos with submodules' test_description='Test shallow cloning of repos with submodules'
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
pwd=$(pwd) pwd=$(pwd)

1
t/t5617-clone-submodules-remote.sh
View File

@ -5,6 +5,7 @@ test_description='Test cloning repos with submodules using remote-tracking branc
GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME=main
export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME export GIT_TEST_DEFAULT_INITIAL_BRANCH_NAME
TEST_PASSES_SANITIZE_LEAK=true
. ./test-lib.sh . ./test-lib.sh
pwd=$(pwd) pwd=$(pwd)