undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fsck.c:fsck_ident(): ident points at a const string

Browse Source 
Since fsck_ident doesn't change the content of **ident, the type of
ident could be const char **.

This change is required to rewrite fsck_commit() to use skip_prefix().

Signed-off-by: Yuxuan Shui <yshuiv7@gmail.com>
Helped-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Yuxuan Shui 2014-03-13 12:45:50 +08:00 committed by Junio C Hamano
parent 5f95c9f850
commit de42180f6a
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
fsck.c
View File

@ -243,7 +243,7 @@ static int fsck_tree(struct tree *item, int strict, fsck_error error_func)
return retval; return retval;
} }
static int fsck_ident(char **ident, struct object *obj, fsck_error error_func) static int fsck_ident(const char **ident, struct object *obj, fsck_error error_func)
{ {
if (**ident == '<') if (**ident == '<')
return error_func(obj, FSCK_ERROR, "invalid author/committer line - missing space before email"); return error_func(obj, FSCK_ERROR, "invalid author/committer line - missing space before email");
@ -281,7 +281,7 @@ static int fsck_ident(char **ident, struct object *obj, fsck_error error_func)
static int fsck_commit(struct commit *commit, fsck_error error_func) static int fsck_commit(struct commit *commit, fsck_error error_func)
{ {
char *buffer = commit->buffer; const char *buffer = commit->buffer;
unsigned char tree_sha1[20], sha1[20]; unsigned char tree_sha1[20], sha1[20];
struct commit_graft *graft; struct commit_graft *graft;
int parents = 0; int parents = 0;