undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

add_rev_cmdline(): make a copy of the name argument

Browse Source 
Instead of assuming that the memory pointed to by the name argument
will live forever, make a local copy of it before storing it in the
ref_cmdline_info.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty 2013-05-25 11:08:02 +02:00 committed by Junio C Hamano
parent b87dbcc899
commit df835d3a0c
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
revision.c
View File

@ -898,6 +898,10 @@ static int limit_list(struct rev_info *revs)
return 0; return 0;
} }
/*
* Add an entry to refs->cmdline with the specified information.
* *name is copied.
*/
static void add_rev_cmdline(struct rev_info *revs, static void add_rev_cmdline(struct rev_info *revs,
struct object *item, struct object *item,
const char *name, const char *name,
@ -909,7 +913,7 @@ static void add_rev_cmdline(struct rev_info *revs,
ALLOC_GROW(info->rev, nr + 1, info->alloc); ALLOC_GROW(info->rev, nr + 1, info->alloc);
info->rev[nr].item = item; info->rev[nr].item = item;
info->rev[nr].name = name; info->rev[nr].name = xstrdup(name);
info->rev[nr].whence = whence; info->rev[nr].whence = whence;
info->rev[nr].flags = flags; info->rev[nr].flags = flags;
info->nr++; info->nr++;