undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

run-command.c: make "struct parallel_processes" const if possible

Browse Source 
Add a "const" to two "struct parallel_processes" parameters where
we're not modifying anything in "pp". For kill_children() we'll call
it from both the signal handler, and from run_processes_parallel()
itself. Adding a "const" there makes it clear that we don't need to
modify any state when killing our children.

Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Ævar Arnfjörð Bjarmason 2022-10-12 23:02:28 +02:00 committed by Junio C Hamano
parent 36d69bf77e
commit e39c9de860
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
run-command.c
View File

@ -1540,7 +1540,7 @@ static int default_task_finished(int result,
return 0; return 0;
} }
static void kill_children(struct parallel_processes *pp, int signo) static void kill_children(const struct parallel_processes *pp, int signo)
{ {
for (size_t i = 0; i < pp->max_processes; i++) for (size_t i = 0; i < pp->max_processes; i++)
if (pp->children[i].state == GIT_CP_WORKING) if (pp->children[i].state == GIT_CP_WORKING)
@ -1698,7 +1698,7 @@ static void pp_buffer_stderr(struct parallel_processes *pp, int output_timeout)
} }
} }
static void pp_output(struct parallel_processes *pp) static void pp_output(const struct parallel_processes *pp)
{ {
size_t i = pp->output_owner; size_t i = pp->output_owner;