undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'jk/hashcmp-memcmp'

Browse Source 
Code clean-up.

* jk/hashcmp-memcmp:
  hashcmp: use memcmp instead of open-coded loop
This commit is contained in:
Junio C Hamano 2017-08-22 10:29:09 -07:00
commit e45bbfc584
1 changed files with 1 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
cache.h
View File

@ -939,14 +939,7 @@ extern const struct object_id null_oid;
static inline int hashcmp(const unsigned char *sha1, const unsigned char *sha2) static inline int hashcmp(const unsigned char *sha1, const unsigned char *sha2)
{ {
int i; return memcmp(sha1, sha2, GIT_SHA1_RAWSZ);
for (i = 0; i < GIT_SHA1_RAWSZ; i++, sha1++, sha2++) {
if (*sha1 != *sha2)
return *sha1 - *sha2;
}
return 0;
} }
static inline int oidcmp(const struct object_id *oid1, const struct object_id *oid2) static inline int oidcmp(const struct object_id *oid1, const struct object_id *oid2)