t4209: factor out helper function test_log_icase()
Reduce code duplication by introducing test_log_icase() that runs the same test with both --regexp-ignore-case and -i. The specification of the four basic test scenarios (matching/nomatching combined with case sensitive/insensitive) becomes easier to read and write. Signed-off-by: Rene Scharfe <l.s.r@web.de> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
57b6dc76f2
commit
e7880fcd41
@ -33,6 +33,12 @@ test_log () {
|
||||
"
|
||||
}
|
||||
|
||||
# test -i and --regexp-ignore-case and expect both to behave the same way
|
||||
test_log_icase () {
|
||||
test_log $@ --regexp-ignore-case
|
||||
test_log $@ -i
|
||||
}
|
||||
|
||||
test_expect_success setup '
|
||||
>expect_nomatch &&
|
||||
|
||||
@ -76,10 +82,8 @@ test_expect_success 'log --author -i' '
|
||||
|
||||
test_log expect_nomatch -G picked
|
||||
test_log expect_second -G Picked
|
||||
test_log expect_nomatch -G pickle --regexp-ignore-case
|
||||
test_log expect_nomatch -G pickle -i
|
||||
test_log expect_second -G picked --regexp-ignore-case
|
||||
test_log expect_second -G picked -i
|
||||
test_log_icase expect_nomatch -G pickle
|
||||
test_log_icase expect_second -G picked
|
||||
|
||||
test_expect_success 'log -G --textconv (missing textconv tool)' '
|
||||
echo "* diff=test" >.gitattributes &&
|
||||
@ -96,10 +100,8 @@ test_expect_success 'log -G --no-textconv (missing textconv tool)' '
|
||||
|
||||
test_log expect_nomatch -S picked
|
||||
test_log expect_second -S Picked
|
||||
test_log expect_second -S picked --regexp-ignore-case
|
||||
test_log expect_second -S picked -i
|
||||
test_log expect_nomatch -S pickle --regexp-ignore-case
|
||||
test_log expect_nomatch -S pickle -i
|
||||
test_log_icase expect_second -S picked
|
||||
test_log_icase expect_nomatch -S pickle
|
||||
|
||||
test_expect_success 'log -S --textconv (missing textconv tool)' '
|
||||
echo "* diff=test" >.gitattributes &&
|
||||
|
Loading…
Reference in New Issue
Block a user