undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[PATCH] fetch.c: Remove useless lookup_object_type() call in process()

Browse Source 
In all places where process() is called except the one in pull() (which
is executed only once) the pointer to the object is already available,
so pass it as the argument to process() instead of sha1 and avoid an
unneeded call to lookup_object_type().

Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Signed-off-by: Junio C Hamano <junkio@cox.net>
This commit is contained in:
Sergey Vlasov 2005-09-21 20:33:54 +04:00 committed by Junio C Hamano
parent 0493a3fd52
commit e8d2a6d483
1 changed files with 10 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
fetch.c
View File

@ -33,7 +33,7 @@ static void report_missing(const char *what, const unsigned char *missing)
what, missing_hex, sha1_to_hex(current_commit_sha1)); what, missing_hex, sha1_to_hex(current_commit_sha1));
} }
static int process(unsigned char *sha1, const char *type); static int process(struct object *obj);
static int process_tree(struct tree *tree) static int process_tree(struct tree *tree)
{ {
@ -46,8 +46,7 @@ static int process_tree(struct tree *tree)
tree->entries = NULL; tree->entries = NULL;
while (entry) { while (entry) {
struct tree_entry_list *next = entry->next; struct tree_entry_list *next = entry->next;
if (process(entry->item.any->sha1, if (process(entry->item.any))
entry->directory ? tree_type : blob_type))
return -1; return -1;
free(entry); free(entry);
entry = next; entry = next;
@ -79,7 +78,7 @@ static int process_commit(struct commit *commit)
pull_say("walk %s\n", sha1_to_hex(commit->object.sha1)); pull_say("walk %s\n", sha1_to_hex(commit->object.sha1));
if (get_tree) { if (get_tree) {
if (process(commit->tree->object.sha1, tree_type)) if (process(&commit->tree->object))
return -1; return -1;
if (!get_all) if (!get_all)
get_tree = 0; get_tree = 0;
@ -87,7 +86,7 @@ static int process_commit(struct commit *commit)
if (get_history) { if (get_history) {
struct commit_list *parents = commit->parents; struct commit_list *parents = commit->parents;
for (; parents; parents = parents->next) { for (; parents; parents = parents->next) {
if (process(parents->item->object.sha1, commit_type)) if (process(&parents->item->object))
return -1; return -1;
} }
} }
@ -98,7 +97,7 @@ static int process_tag(struct tag *tag)
{ {
if (parse_tag(tag)) if (parse_tag(tag))
return -1; return -1;
return process(tag->tagged->sha1, NULL); return process(tag->tagged);
} }
static struct object_list *process_queue = NULL; static struct object_list *process_queue = NULL;
@ -133,12 +132,10 @@ static int process_object(struct object *obj)
obj->type, sha1_to_hex(obj->sha1)); obj->type, sha1_to_hex(obj->sha1));
} }
static int process(unsigned char *sha1, const char *type) static int process(struct object *obj)
{ {
struct object *obj = lookup_object_type(sha1, type); if (has_sha1_file(obj->sha1)) {
parse_object(obj->sha1);
if (has_sha1_file(sha1)) {
parse_object(sha1);
/* We already have it, so we should scan it now. */ /* We already have it, so we should scan it now. */
if (obj->flags & (SCANNED | TO_SCAN)) if (obj->flags & (SCANNED | TO_SCAN))
return 0; return 0;
@ -153,7 +150,7 @@ static int process(unsigned char *sha1, const char *type)
process_queue_end = &(*process_queue_end)->next; process_queue_end = &(*process_queue_end)->next;
obj->flags |= TO_FETCH; obj->flags |= TO_FETCH;
prefetch(sha1); prefetch(obj->sha1);
return 0; return 0;
} }
@ -228,7 +225,7 @@ int pull(char *target)
if (interpret_target(target, sha1)) if (interpret_target(target, sha1))
return error("Could not interpret %s as something to pull", return error("Could not interpret %s as something to pull",
target); target);
if (process(sha1, NULL)) if (process(lookup_unknown_object(sha1)))
return -1; return -1;
if (loop()) if (loop())
return -1; return -1;