undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

ref-filter: strip format option after a field name only once while parsing

Browse Source 
When parse_ref_filter_atom() iterates over a list of valid atoms to
check that a field name is one of them, it has to strip the optional
colon-separated format option suffix that might follow the field name.
However, it does so inside the loop, i.e. it performs the exact same
stripping over and over again.

Move stripping the format option suffix out of that loop, so it's only
performed once for each parsed field name.

Signed-off-by: SZEDER Gábor <szeder@ira.uka.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
SZEDER Gábor 2016-10-02 18:35:11 +02:00 committed by Junio C Hamano
parent 92d426662b
commit e94ce1394e
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
ref-filter.c
View File

@ -235,7 +235,7 @@ int parse_ref_filter_atom(const char *atom, const char *ep)
{ {
const char *sp; const char *sp;
const char *arg; const char *arg;
int i, at; int i, at, atom_len;
sp = atom; sp = atom;
if (*sp == '*' && sp < ep) if (*sp == '*' && sp < ep)
@ -250,10 +250,6 @@ int parse_ref_filter_atom(const char *atom, const char *ep)
return i; return i;
} }
/* Is the atom a valid one? */
for (i = 0; i < ARRAY_SIZE(valid_atom); i++) {
int len = strlen(valid_atom[i].name);
/* /*
* If the atom name has a colon, strip it and everything after * If the atom name has a colon, strip it and everything after
* it off - it specifies the format for this entry, and * it off - it specifies the format for this entry, and
@ -261,8 +257,12 @@ int parse_ref_filter_atom(const char *atom, const char *ep)
* table. * table.
*/ */
arg = memchr(sp, ':', ep - sp); arg = memchr(sp, ':', ep - sp);
if (len == (arg ? arg : ep) - sp && atom_len = (arg ? arg : ep) - sp;
!memcmp(valid_atom[i].name, sp, len))
/* Is the atom a valid one? */
for (i = 0; i < ARRAY_SIZE(valid_atom); i++) {
int len = strlen(valid_atom[i].name);
if (len == atom_len && !memcmp(valid_atom[i].name, sp, len))
break; break;
} }