undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

show <tag>: reuse pp_user_info() instead of duplicating code

Browse Source 
We used to extract the tagger information "by hand" in "git show <tag>",
but the function pp_user_info() already does that.  Even better:
it respects the commit_format and date_format specified by the user.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2009-01-02 19:08:43 +01:00 committed by Junio C Hamano
parent df63fbbf46
commit ea718e65fa
1 changed files with 6 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

21
builtin-log.c
View File

@ -249,22 +249,13 @@ int cmd_whatchanged(int argc, const char **argv, const char *prefix)
static void show_tagger(char *buf, int len, struct rev_info *rev) static void show_tagger(char *buf, int len, struct rev_info *rev)
{ {
char *email_end, *p; struct strbuf out = STRBUF_INIT;
unsigned long date;
int tz;
email_end = memchr(buf, '>', len); pp_user_info("Tagger", rev->commit_format, &out, buf, rev->date_mode,
if (!email_end) git_log_output_encoding ?
return; git_log_output_encoding: git_commit_encoding);
p = ++email_end; printf("%s\n", out.buf);
while (isspace(*p)) strbuf_release(&out);
p++;
date = strtoul(p, &p, 10);
while (isspace(*p))
p++;
tz = (int)strtol(p, NULL, 10);
printf("Tagger: %.*s\nDate: %s\n", (int)(email_end - buf), buf,
show_date(date, tz, rev->date_mode));
} }
static int show_object(const unsigned char *sha1, int show_tag_object, static int show_object(const unsigned char *sha1, int show_tag_object,