undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

pack-format: correct multi-pack-index description

Browse Source 
The description of the multi-pack-index contains a small bug,
if all offsets are < 2^32 then there will be no LOFF chunk,
not only if they're all < 2^31 (since the highest bit is only
needed as the "LOFF-escape" when that's actually needed.)

Correct this, and clarify that in that case only offsets up
to 2^31-1 can be stored in the OOFF chunk.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Acked-by: Derrick Stolee <dstolee@microsoft.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Berg 2020-02-07 23:16:40 +01:00 committed by Junio C Hamano
parent a7312d1a28
commit eb31044ff7
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Documentation/technical/pack-format.txt
View File

@ -315,10 +315,11 @@ CHUNK DATA:
Stores two 4-byte values for every object. Stores two 4-byte values for every object.
1: The pack-int-id for the pack storing this object. 1: The pack-int-id for the pack storing this object.
2: The offset within the pack. 2: The offset within the pack.
If all offsets are less than 2^31, then the large offset chunk If all offsets are less than 2^32, then the large offset chunk
will not exist and offsets are stored as in IDX v1. will not exist and offsets are stored as in IDX v1.
If there is at least one offset value larger than 2^32-1, then If there is at least one offset value larger than 2^32-1, then
the large offset chunk must exist. If the large offset chunk the large offset chunk must exist, and offsets larger than
2^31-1 must be stored in it instead. If the large offset chunk
exists and the 31st bit is on, then removing that bit reveals exists and the 31st bit is on, then removing that bit reveals
the row in the large offsets containing the 8-byte offset of the row in the large offsets containing the 8-byte offset of
this object. this object.