undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

apply --index-info: fall back to current index for mode changes

Browse Source 
"git diff" does not record index lines for pure mode changes (i.e. no
lines changed).  Therefore, apply --index-info would call out a bogus
error.

Instead, fall back to reading the info from the current index.

Incidentally, this fixes an error where git-rebase would not rebase a
commit including a pure mode change, and changes requiring a threeway
merge.

Noticed and later tested by Chris Shoemaker.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Johannes Schindelin 2007-09-17 01:24:57 +01:00 committed by Junio C Hamano
parent f3caeb9ac2
commit ece7b74903
2 changed files with 39 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
builtin-apply.c
View File

@ -2227,6 +2227,20 @@ static int check_patch_list(struct patch *patch)
return err; return err;
} }
/* This function tries to read the sha1 from the current index */
static int get_current_sha1(const char *path, unsigned char *sha1)
{
int pos;
if (read_cache() < 0)
return -1;
pos = cache_name_pos(path, strlen(path));
if (pos < 0)
return -1;
hashcpy(sha1, active_cache[pos]->sha1);
return 0;
}
static void show_index_list(struct patch *list) static void show_index_list(struct patch *list)
{ {
struct patch *patch; struct patch *patch;
@ -2243,8 +2257,16 @@ static void show_index_list(struct patch *list)
if (0 < patch->is_new) if (0 < patch->is_new)
sha1_ptr = null_sha1; sha1_ptr = null_sha1;
else if (get_sha1(patch->old_sha1_prefix, sha1)) else if (get_sha1(patch->old_sha1_prefix, sha1))
die("sha1 information is lacking or useless (%s).", /* git diff has no index line for mode/type changes */
name); if (!patch->lines_added && !patch->lines_deleted) {
if (get_current_sha1(patch->new_name, sha1) ||
get_current_sha1(patch->old_name, sha1))
die("mode change for %s, which is not "
"in current HEAD", name);
sha1_ptr = sha1;
} else
die("sha1 information is lacking or useless "
"(%s).", name);
else else
sha1_ptr = sha1; sha1_ptr = sha1;

15
t/t3400-rebase.sh
View File

@ -68,4 +68,19 @@ test_expect_success \
test 3 = $(git rev-list master.. | wc -l) test 3 = $(git rev-list master.. | wc -l)
' '
test_expect_success 'rebase a single mode change' '
git checkout master &&
echo 1 > X &&
git add X &&
test_tick &&
git commit -m prepare &&
git checkout -b modechange HEAD^ &&
echo 1 > X &&
git add X &&
chmod a+x A &&
test_tick &&
git commit -m modechange A X &&
GIT_TRACE=1 git rebase master
'
test_done test_done