Merge branch 'jh/update-ref-d-through-symref' into maint
* jh/update-ref-d-through-symref: Fix failure to delete a packed ref through a symref t1400-update-ref: Add test verifying bug with symrefs in delete_ref()
This commit is contained in:
commit
ed20513c8d
2
refs.c
2
refs.c
@ -1770,7 +1770,7 @@ int delete_ref(const char *refname, const unsigned char *sha1, int delopt)
|
|||||||
* packed one. Also, if it was not loose we need to repack
|
* packed one. Also, if it was not loose we need to repack
|
||||||
* without it.
|
* without it.
|
||||||
*/
|
*/
|
||||||
ret |= repack_without_ref(refname);
|
ret |= repack_without_ref(lock->ref_name);
|
||||||
|
|
||||||
unlink_or_warn(git_path("logs/%s", lock->ref_name));
|
unlink_or_warn(git_path("logs/%s", lock->ref_name));
|
||||||
invalidate_ref_cache(NULL);
|
invalidate_ref_cache(NULL);
|
||||||
|
@ -74,6 +74,24 @@ test_expect_success "delete $m (by HEAD)" '
|
|||||||
'
|
'
|
||||||
rm -f .git/$m
|
rm -f .git/$m
|
||||||
|
|
||||||
|
test_expect_success \
|
||||||
|
"create $m (by HEAD)" \
|
||||||
|
"git update-ref HEAD $A &&
|
||||||
|
test $A"' = $(cat .git/'"$m"')'
|
||||||
|
test_expect_success \
|
||||||
|
"pack refs" \
|
||||||
|
"git pack-refs --all"
|
||||||
|
test_expect_success \
|
||||||
|
"move $m (by HEAD)" \
|
||||||
|
"git update-ref HEAD $B $A &&
|
||||||
|
test $B"' = $(cat .git/'"$m"')'
|
||||||
|
test_expect_success "delete $m (by HEAD) should remove both packed and loose $m" '
|
||||||
|
git update-ref -d HEAD $B &&
|
||||||
|
! grep "$m" .git/packed-refs &&
|
||||||
|
! test -f .git/$m
|
||||||
|
'
|
||||||
|
rm -f .git/$m
|
||||||
|
|
||||||
cp -f .git/HEAD .git/HEAD.orig
|
cp -f .git/HEAD .git/HEAD.orig
|
||||||
test_expect_success "delete symref without dereference" '
|
test_expect_success "delete symref without dereference" '
|
||||||
git update-ref --no-deref -d HEAD &&
|
git update-ref --no-deref -d HEAD &&
|
||||||
|
Loading…
Reference in New Issue
Block a user