undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

rebase--interactive: move transform_todo_file()

Browse Source 
As transform_todo_file() is only needed inside of
rebase--interactive.c for `rebase -p', it is moved there from
sequencer.c.

The parameter r (repository) is dropped along the way.

Signed-off-by: Alban Gruin <alban.gruin@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Alban Gruin 2019-03-05 20:18:05 +01:00 committed by Junio C Hamano
parent 1451d0f616
commit ed35d18841
3 changed files with 25 additions and 25 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
builtin/rebase--interactive.c
View File

@ -64,6 +64,30 @@ static int rearrange_squash_in_todo_file(void)
return 0; return 0;
} }
static int transform_todo_file(unsigned flags)
{
const char *todo_file = rebase_path_todo();
struct todo_list todo_list = TODO_LIST_INIT;
int res;
if (strbuf_read_file(&todo_list.buf, todo_file, 0) < 0)
return error_errno(_("could not read '%s'."), todo_file);
if (todo_list_parse_insn_buffer(the_repository, todo_list.buf.buf,
&todo_list)) {
todo_list_release(&todo_list);
return error(_("unusable todo list: '%s'"), todo_file);
}
res = todo_list_write_to_file(the_repository, &todo_list, todo_file,
NULL, NULL, -1, flags);
todo_list_release(&todo_list);
if (res)
return error_errno(_("could not write '%s'."), todo_file);
return 0;
}
static int edit_todo_file(unsigned flags) static int edit_todo_file(unsigned flags)
{ {
const char *todo_file = rebase_path_todo(); const char *todo_file = rebase_path_todo();
@ -330,7 +354,7 @@ int cmd_rebase__interactive(int argc, const char **argv, const char *prefix)
} }
case SHORTEN_OIDS: case SHORTEN_OIDS:
case EXPAND_OIDS: case EXPAND_OIDS:
ret = transform_todo_file(the_repository, flags); ret = transform_todo_file(flags);
break; break;
case CHECK_TODO_LIST: case CHECK_TODO_LIST:
ret = check_todo_list_from_file(the_repository); ret = check_todo_list_from_file(the_repository);

23
sequencer.c
View File

@ -4632,29 +4632,6 @@ int todo_list_write_to_file(struct repository *r, struct todo_list *todo_list,
return res; return res;
} }
int transform_todo_file(struct repository *r, unsigned flags)
{
const char *todo_file = rebase_path_todo();
struct todo_list todo_list = TODO_LIST_INIT;
int res;
if (strbuf_read_file(&todo_list.buf, todo_file, 0) < 0)
return error_errno(_("could not read '%s'."), todo_file);
if (todo_list_parse_insn_buffer(r, todo_list.buf.buf, &todo_list)) {
todo_list_release(&todo_list);
return error(_("unusable todo list: '%s'"), todo_file);
}
res = todo_list_write_to_file(r, &todo_list, todo_file,
NULL, NULL, -1, flags);
todo_list_release(&todo_list);
if (res)
return error_errno(_("could not write '%s'."), todo_file);
return 0;
}
static const char edit_todo_list_advice[] = static const char edit_todo_list_advice[] =
N_("You can fix this with 'git rebase --edit-todo' " N_("You can fix this with 'git rebase --edit-todo' "
"and then run 'git rebase --continue'.\n" "and then run 'git rebase --continue'.\n"

1
sequencer.h
View File

@ -143,7 +143,6 @@ int sequencer_remove_state(struct replay_opts *opts);
int sequencer_make_script(struct repository *r, struct strbuf *out, int argc, int sequencer_make_script(struct repository *r, struct strbuf *out, int argc,
const char **argv, unsigned flags); const char **argv, unsigned flags);
int transform_todo_file(struct repository *r, unsigned flags);
void todo_list_add_exec_commands(struct todo_list *todo_list, void todo_list_add_exec_commands(struct todo_list *todo_list,
struct string_list *commands); struct string_list *commands);
int check_todo_list_from_file(struct repository *r); int check_todo_list_from_file(struct repository *r);