undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

gitweb: Silence 'Variable VAR may be unavailable' warnings

Browse Source 
When $projects_list points to a directory, and git_get_projects_list
scans this directory for repositories, there can be generated the
following warnings (for persistent services like mod_perl or plackup):

  Variable "$project_maxdepth" may be unavailable at gitweb.cgi line 2443.
  Variable "$projectroot" may be unavailable at gitweb.cgi line 2451.

Those are false positives; silence those warnings by explicitely
declaring $project_maxdepth and $projectroot with 'our', as global
variables, in anonymous subrotine passed to File::Find::find.

Signed-off-by: Jakub Narebski <jnareb@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jakub Narebski 2010-04-30 18:30:31 +02:00 committed by Junio C Hamano
parent ca5e949560
commit ee1d8ee0f0
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
gitweb/gitweb.perl
View File

@ -1520,6 +1520,9 @@ sub git_get_projects_list {
follow_skip => 2, # ignore duplicates follow_skip => 2, # ignore duplicates
dangling_symlinks => 0, # ignore dangling symlinks, silently dangling_symlinks => 0, # ignore dangling symlinks, silently
wanted => sub { wanted => sub {
# global variables
our $project_maxdepth;
our $projectroot;
# skip project-list toplevel, if we get it. # skip project-list toplevel, if we get it.
return if (m!^[/.]$!); return if (m!^[/.]$!);
# only directories can be git repositories # only directories can be git repositories