From ef2d2acceffaa426e27ad21350fb707ddb5f5eec Mon Sep 17 00:00:00 2001 From: Eric Sunshine Date: Fri, 13 Jul 2018 01:52:03 -0400 Subject: [PATCH] t/check-non-portable-shell: stop being so polite Error messages emitted by this linting script are long and noisy, consisting of several sections: :: error: : Many problem explanations ask the reader to "please" use a suggested alternative, however, such politeness is unnecessary and just adds to the noise and length of the line, so drop "please" to make the message a bit more concise. Signed-off-by: Eric Sunshine Signed-off-by: Junio C Hamano --- t/check-non-portable-shell.pl | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl index e07f028437..11028578ff 100755 --- a/t/check-non-portable-shell.pl +++ b/t/check-non-portable-shell.pl @@ -17,12 +17,12 @@ sub err { while (<>) { chomp; /\bsed\s+-i/ and err 'sed -i is not portable'; - /\becho\s+-[neE]/ and err 'echo with option is not portable (please use printf)'; + /\becho\s+-[neE]/ and err 'echo with option is not portable (use printf)'; /^\s*declare\s+/ and err 'arrays/declare not portable'; - /^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)'; - /\btest\s+[^=]*==/ and err '"test a == b" is not portable (please use =)'; - /\bwc -l.*"\s*=/ and err '`"$(wc -l)"` is not portable (please use test_line_count)'; - /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (please use FOO=bar && export FOO)'; + /^\s*[^#]\s*which\s/ and err 'which is not portable (use type)'; + /\btest\s+[^=]*==/ and err '"test a == b" is not portable (use =)'; + /\bwc -l.*"\s*=/ and err '`"$(wc -l)"` is not portable (use test_line_count)'; + /\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable (use FOO=bar && export FOO)'; # this resets our $. for each file close ARGV if eof; }