config.c: use error_errno()
Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
parent
df8e31391d
commit
f0658ec9ea
22
config.c
22
config.c
@ -2016,7 +2016,7 @@ int git_config_set_multivar_in_file_gently(const char *config_filename,
|
||||
lock = xcalloc(1, sizeof(struct lock_file));
|
||||
fd = hold_lock_file_for_update(lock, config_filename, 0);
|
||||
if (fd < 0) {
|
||||
error("could not lock config file %s: %s", config_filename, strerror(errno));
|
||||
error_errno("could not lock config file %s", config_filename);
|
||||
free(store.key);
|
||||
ret = CONFIG_NO_LOCK;
|
||||
goto out_free;
|
||||
@ -2030,8 +2030,7 @@ int git_config_set_multivar_in_file_gently(const char *config_filename,
|
||||
free(store.key);
|
||||
|
||||
if ( ENOENT != errno ) {
|
||||
error("opening %s: %s", config_filename,
|
||||
strerror(errno));
|
||||
error_errno("opening %s", config_filename);
|
||||
ret = CONFIG_INVALID_FILE; /* same as "invalid config file" */
|
||||
goto out_free;
|
||||
}
|
||||
@ -2115,8 +2114,7 @@ int git_config_set_multivar_in_file_gently(const char *config_filename,
|
||||
if (contents == MAP_FAILED) {
|
||||
if (errno == ENODEV && S_ISDIR(st.st_mode))
|
||||
errno = EISDIR;
|
||||
error("unable to mmap '%s': %s",
|
||||
config_filename, strerror(errno));
|
||||
error_errno("unable to mmap '%s'", config_filename);
|
||||
ret = CONFIG_INVALID_FILE;
|
||||
contents = NULL;
|
||||
goto out_free;
|
||||
@ -2125,8 +2123,7 @@ int git_config_set_multivar_in_file_gently(const char *config_filename,
|
||||
in_fd = -1;
|
||||
|
||||
if (chmod(get_lock_file_path(lock), st.st_mode & 07777) < 0) {
|
||||
error("chmod on %s failed: %s",
|
||||
get_lock_file_path(lock), strerror(errno));
|
||||
error_errno("chmod on %s failed", get_lock_file_path(lock));
|
||||
ret = CONFIG_NO_WRITE;
|
||||
goto out_free;
|
||||
}
|
||||
@ -2182,8 +2179,7 @@ int git_config_set_multivar_in_file_gently(const char *config_filename,
|
||||
}
|
||||
|
||||
if (commit_lock_file(lock) < 0) {
|
||||
error("could not write config file %s: %s", config_filename,
|
||||
strerror(errno));
|
||||
error_errno("could not write config file %s", config_filename);
|
||||
ret = CONFIG_NO_WRITE;
|
||||
lock = NULL;
|
||||
goto out_free;
|
||||
@ -2330,8 +2326,8 @@ int git_config_rename_section_in_file(const char *config_filename,
|
||||
fstat(fileno(config_file), &st);
|
||||
|
||||
if (chmod(get_lock_file_path(lock), st.st_mode & 07777) < 0) {
|
||||
ret = error("chmod on %s failed: %s",
|
||||
get_lock_file_path(lock), strerror(errno));
|
||||
ret = error_errno("chmod on %s failed",
|
||||
get_lock_file_path(lock));
|
||||
goto out;
|
||||
}
|
||||
|
||||
@ -2385,8 +2381,8 @@ int git_config_rename_section_in_file(const char *config_filename,
|
||||
fclose(config_file);
|
||||
unlock_and_out:
|
||||
if (commit_lock_file(lock) < 0)
|
||||
ret = error("could not write config file %s: %s",
|
||||
config_filename, strerror(errno));
|
||||
ret = error_errno("could not write config file %s",
|
||||
config_filename);
|
||||
out:
|
||||
free(filename_buf);
|
||||
return ret;
|
||||
|
Loading…
Reference in New Issue
Block a user