undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-gui: When calling post-commit hook wrong variable was cleared.

Browse Source 
Before calling the post-commit hook, the variable "pc_err" is cleared
while later only "pch_error" is used. "pch_error$cmt_id" only appeared in
"upvar"-Statements (which were changed to "global") and was removed.

Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
This commit is contained in:
Jens Lehmann 2009-03-30 20:35:57 +02:00 committed by Shawn O. Pearce
parent 3eb5682b0b
commit f0d4eec99f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
lib/commit.tcl
View File

@ -407,8 +407,8 @@ A rescan will be automatically started now.
# #
set fd_ph [githook_read post-commit] set fd_ph [githook_read post-commit]
if {$fd_ph ne {}} { if {$fd_ph ne {}} {
upvar #0 pch_error$cmt_id pc_err global pch_error
set pc_err {} set pch_error {}
fconfigure $fd_ph -blocking 0 -translation binary -eofchar {} fconfigure $fd_ph -blocking 0 -translation binary -eofchar {}
fileevent $fd_ph readable \ fileevent $fd_ph readable \
[list commit_postcommit_wait $fd_ph $cmt_id] [list commit_postcommit_wait $fd_ph $cmt_id]
@ -470,7 +470,7 @@ A rescan will be automatically started now.
} }
proc commit_postcommit_wait {fd_ph cmt_id} { proc commit_postcommit_wait {fd_ph cmt_id} {
upvar #0 pch_error$cmt_id pch_error global pch_error
append pch_error [read $fd_ph] append pch_error [read $fd_ph]
fconfigure $fd_ph -blocking 1 fconfigure $fd_ph -blocking 1