undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge branch 'mt/add-chmod-fixes'

Browse Source 
Various fixes on "git add --chmod".

* mt/add-chmod-fixes:
  add: propagate --chmod errors to exit status
  add: mark --chmod error string for translation
  add --chmod: don't update index when --dry-run is used
This commit is contained in:
Junio C Hamano 2021-02-25 16:43:31 -08:00
commit f277234860
2 changed files with 54 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
builtin/add.c
View File

@ -38,19 +38,27 @@ struct update_callback_data {
int add_errors;
};
static void chmod_pathspec(struct pathspec *pathspec, char flip)
static int chmod_pathspec(struct pathspec *pathspec, char flip, int show_only)
{
int i;
int i, ret = 0;
for (i = 0; i < active_nr; i++) {
struct cache_entry *ce = active_cache[i];
int err;
if (pathspec && !ce_path_match(&the_index, ce, pathspec, NULL))
continue;
if (chmod_cache_entry(ce, flip) < 0)
fprintf(stderr, "cannot chmod %cx '%s'\n", flip, ce->name);
if (!show_only)
err = chmod_cache_entry(ce, flip);
else
err = S_ISREG(ce->ce_mode) ? 0 : -1;
if (err < 0)
ret = error(_("cannot chmod %cx '%s'"), flip, ce->name);
}
return ret;
}
static int fix_unmerged_status(struct diff_filepair *p,
@ -609,7 +617,7 @@ int cmd_add(int argc, const char **argv, const char *prefix)
exit_status |= add_files(&dir, flags);
if (chmod_arg && pathspec.nr)
chmod_pathspec(&pathspec, chmod_arg[0]);
exit_status |= chmod_pathspec(&pathspec, chmod_arg[0], show_only);
unplug_bulk_checkin();
finish:

46
t/t3700-add.sh
View File

@ -386,6 +386,36 @@ test_expect_success POSIXPERM 'git add --chmod=[+-]x does not change the working
! test -x foo4
'
test_expect_success 'git add --chmod fails with non regular files (but updates the other paths)' '
git reset --hard &&
test_ln_s_add foo foo3 &&
touch foo4 &&
test_must_fail git add --chmod=+x foo3 foo4 2>stderr &&
test_i18ngrep "cannot chmod +x .foo3." stderr &&
test_mode_in_index 120000 foo3 &&
test_mode_in_index 100755 foo4
'
test_expect_success 'git add --chmod honors --dry-run' '
git reset --hard &&
echo foo >foo4 &&
git add foo4 &&
git add --chmod=+x --dry-run foo4 &&
test_mode_in_index 100644 foo4
'
test_expect_success 'git add --chmod --dry-run reports error for non regular files' '
git reset --hard &&
test_ln_s_add foo foo4 &&
test_must_fail git add --chmod=+x --dry-run foo4 2>stderr &&
test_i18ngrep "cannot chmod +x .foo4." stderr
'
test_expect_success 'git add --chmod --dry-run reports error for unmatched pathspec' '
test_must_fail git add --chmod=+x --dry-run nonexistent 2>stderr &&
test_i18ngrep "pathspec .nonexistent. did not match any files" stderr
'
test_expect_success 'no file status change if no pathspec is given' '
>foo5 &&
>foo6 &&
@ -409,11 +439,17 @@ test_expect_success 'no file status change if no pathspec is given in subdir' '
'
test_expect_success 'all statuses changed in folder if . is given' '
rm -fr empty &&
git add --chmod=+x . &&
test $(git ls-files --stage | grep ^100644 | wc -l) -eq 0 &&
git add --chmod=-x . &&
test $(git ls-files --stage | grep ^100755 | wc -l) -eq 0
git init repo &&
(
cd repo &&
mkdir -p sub/dir &&
touch x y z sub/a sub/dir/b &&
git add -A &&
git add --chmod=+x . &&
test $(git ls-files --stage | grep ^100644 | wc -l) -eq 0 &&
git add --chmod=-x . &&
test $(git ls-files --stage | grep ^100755 | wc -l) -eq 0
)
'
test_expect_success CASE_INSENSITIVE_FS 'path is case-insensitive' '