undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

tests: make test_expect_code quieter on success

Browse Source 
A command exiting with the expected status is not particularly
notable.

While the indication of progress might be useful when tracking down
where in a test a failure has happened, the same applies to most other
test helpers, which are quiet about success, so this single helper's
output stands out in an unpleasant way.  An alternative method for
showing progress information might to invent a --progress option that
runs tests with "set -x", or until that is available, to run tests
using commands like

	prove -v -j2 --shuffle --exec='sh -x' t2202-add-addremove.sh

Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Jonathan Nieder 2011-05-21 14:40:32 -05:00 committed by Junio C Hamano
parent ea2ca4497b
commit f5b7ce1b90
1 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
t/test-lib.sh
View File

@ -731,12 +731,11 @@ test_expect_code () {
exit_code=$?
if test $exit_code = $want_code
then
echo >&2 "test_expect_code: command exited with $exit_code: $*"
return 0
else
echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code $*"
return 1
fi
echo >&2 "test_expect_code: command exited with $exit_code, we wanted $want_code $*"
return 1
}
# test_cmp is a helper function to compare actual and expected output.