undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

for-each-ref: clean up code

Browse Source 
In 'grab_single_ref()' remove the extra count variable 'cnt' and
use the variable 'grab_cnt' of structure 'grab_ref_cbdata' directly
instead.

Mentored-by: Christian Couder <christian.couder@gmail.com>
Mentored-by: Matthieu Moy <matthieu.moy@grenoble-inp.fr>
Signed-off-by: Karthik Nayak <karthik.188@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Karthik Nayak 2015-06-14 01:07:20 +05:30 committed by Junio C Hamano
parent ed01e206ba
commit fc80edcae1
1 changed files with 2 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
builtin/for-each-ref.c
View File

@ -897,7 +897,6 @@ static int grab_single_ref(const char *refname, const struct object_id *oid,
{ {
struct grab_ref_cbdata *cb = cb_data; struct grab_ref_cbdata *cb = cb_data;
struct refinfo *ref; struct refinfo *ref;
int cnt;
if (flag & REF_BAD_NAME) { if (flag & REF_BAD_NAME) {
warning("ignoring ref with broken name %s", refname); warning("ignoring ref with broken name %s", refname);
@ -914,10 +913,8 @@ static int grab_single_ref(const char *refname, const struct object_id *oid,
*/ */
ref = new_refinfo(refname, oid->hash, flag); ref = new_refinfo(refname, oid->hash, flag);
cnt = cb->grab_cnt; REALLOC_ARRAY(cb->grab_array, cb->grab_cnt + 1);
REALLOC_ARRAY(cb->grab_array, cnt + 1); cb->grab_array[cb->grab_cnt++] = ref;
cb->grab_array[cnt++] = ref;
cb->grab_cnt = cnt;
return 0; return 0;
} }