undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

git-svn log: fix ascending revision ranges

Browse Source 
Fixed typo in Git::SVN::Log::git_svn_log_cmd().  Previously a command like
"git-svn log -r1:4" would only show a commit log separator.

Added tests for ascending and descending revision ranges.

Signed-off-by: David D Kilzer <ddkilzer@kilzer.net>
Acked-by: Eric Wong <normalperson@yhbt.net>
This commit is contained in:
David D Kilzer 2007-11-10 22:10:33 -08:00 committed by Eric Wong
parent 3caf320ba8
commit fede44b2e1
2 changed files with 15 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
git-svn.perl
View File

@ -3798,7 +3798,7 @@ sub git_svn_log_cmd {
$c_max = $gs->rev_db_get($r_max);
$c_min = $gs->rev_db_get($r_min);
if (defined $c_min && defined $c_max) {
if ($r_max > $r_max) {
if ($r_max > $r_min) {
push @cmd, "$c_min..$c_max";
} else {
push @cmd, "$c_max..$c_min";

14
t/t9116-git-svn-log.sh
View File

@ -45,4 +45,18 @@ test_expect_success 'run log against a from trunk' "
git svn log -r3 a | grep ^r3
"
printf 'r2 \nr4 \n' > expected-range-r2-r4
test_expect_success 'test ascending revision range' "
git reset --hard trunk &&
git svn log -r 1:4 | grep '^r[0-9]' | cut -d'|' -f1 | diff -u expected-range-r2-r4 -
"
printf 'r4 \nr2 \n' > expected-range-r4-r2
test_expect_success 'test descending revision range' "
git reset --hard trunk &&
git svn log -r 4:1 | grep '^r[0-9]' | cut -d'|' -f1 | diff -u expected-range-r4-r2 -
"
test_done