undef/git-commit-vandalism
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

cmd_fetch_pack(): combine the loop termination conditions

Browse Source 
If an argument that does not start with '-' is found, the loop is
terminated.  So move that check into the for-loop condition.

Signed-off-by: Michael Haggerty <mhagger@alum.mit.edu>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
This commit is contained in:
Michael Haggerty 2012-05-21 09:59:58 +02:00 committed by Junio C Hamano
parent 4cc00fcf5d
commit ff22ff9909
1 changed files with 55 additions and 58 deletions

5
builtin/fetch-pack.c
View File

@ -910,10 +910,9 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
packet_trace_identity("fetch-pack");
heads = NULL;
for (i = 1; i < argc; i++) {
for (i = 1; i < argc && *argv[i] == '-'; i++) {
const char *arg = argv[i];
if (*arg == '-') {
if (!prefixcmp(arg, "--upload-pack=")) {
args.uploadpack = arg + 14;
continue;
@ -970,8 +969,6 @@ int cmd_fetch_pack(int argc, const char **argv, const char *prefix)
}
usage(fetch_pack_usage);
}
break;
}
if (i < argc)
dest = argv[i++];