Commit Graph

1670 Commits

Author SHA1 Message Date
Junio C Hamano
89e2c5f17b Add commit hook and make the verification customizable.
There are three hooks:

    - 'pre-commit' is given an opportunity to inspect what is
      being committed, before we invoke the EDITOR for the
      commit message;

    - 'commit-msg' is invoked on the commit log message after
      the user prepares it;

    - 'post-commit' is run after a successful commit is made.

The first two can interfere to stop the commit.  The last one is
for after-the-fact notification.

The earlier built-in commit checker is now moved to pre-commit.

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-19 16:23:31 -07:00
Junio C Hamano
e20ce6ac76 [PATCH] Allow file removal when "git commit --all" is used.
After you deleted files from your working tree, automatic
git-update-cache used when the "--all" flag is given to "git
commit" barfs because it lacks the --remove flag.

It can be argued that this is a feature; people should be
careful and something with a grave consequence like removing
files should be done manually, in which case the current
behaviour may be OK.

The patch is for people who thinks the user who uses the "--all"
flag deserves the danger that comes with the convenience.

Comments?

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-19 16:19:16 -07:00
Junio C Hamano
b30245c8e9 Merge from gitk 2005-08-19 16:15:59 -07:00
Junio C Hamano
0026d54841 Merge with master for a couple more fixes. 2005-08-19 13:55:59 -07:00
Sergey Vlasov
7f1335c74c [PATCH] git-rev-list: avoid crash on broken repository
When following tags, check for parse_object() success and error out
properly instead of segfaulting.

Signed-off-by: Sergey Vlasov <vsu@altlinux.ru>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-19 13:07:43 -07:00
Marco Costalba
cc5625a5e2 [PATCH] Fix git-format-patch-script to handle empty messages
In case of a commit with an empty message there is no
mandatory empty line between headers and body

[jc: This makes --mbox output valid even when the commit message does
not have anything but its first line, which the one I wrote botched.
One side-effect is that it adds an extra blank line at the end even if
it has more than one lines, which will be eaten by the receiving end.
As Marco says, this is a stop-gap measure.  This script needs to be
split into two, one that gets the format specifier and a commit ID to
write to its standard output, and another that drives that one reading
from rev-list.  I'll fix things properly when that happens by
rewriting the former part in Perl or something more reasonable than
the current shell, sed and grep mishmash.]

Signed-off-by: Marco Costalba <mcostalba@yahoo.it>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-19 11:32:54 -07:00
Paul Mackerras
106288cb02 Display the contents of a tag when the user clicks on it.
This just displays the result of git-cat-file on the tag in the
details pane.  If the tag is a "direct" tag (the tag file contains
the SHA1 ID of a commit rather than a tag), we show the tag name
and SHA1 ID.
2005-08-19 23:11:39 +10:00
Paul Mackerras
f1d83ba34c Added re-read refs command, and display all refs.
These are features requested by Junio.  Any plain file under .git/refs
whose contents start with 40 hex characters is taken as a reference
and displayed like a head but with a light blue background (unless it
is in .git/refs/tags or .git/refs/heads, in which case it is displayed
as before).  There is now a "Reread references" menu item in the File
menu which re-reads all the plain files under .git/refs and redisplays
any references that have changed.
2005-08-19 22:14:28 +10:00
Junio C Hamano
f1d090e13a Fix __attribute__ changes.
It cannot be checked with #ifndef, if you really think about what it
does which cannot be done only with the preprocessor.  My thinko.

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-19 02:06:52 -07:00
Junio C Hamano
14022f5b1c Merge with master to pick up safety patches. 2005-08-18 22:10:50 -07:00
Jason Riedy
75ea6911d6 [PATCH] Spell __attribute__ correctly in cache.h.
Sun's cc doesn't know __attribute__.

Signed-off-by: Jason Riedy <ejr@cs.berkeley.edu>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-18 21:55:46 -07:00
Paul Mackerras
04c13d3877 Save the maxwidth setting in the ~/.gitk file. 2005-08-19 10:22:24 +10:00
Paul Mackerras
022bc2ac74 Fix a bug where commits with no children weren't marked as on-screen.
This problem was revealed by running gitk --all on Wolfgang Denk's
u-boot repository.
2005-08-19 10:22:04 +10:00
Junio C Hamano
a8055f8a8e Also make git-rebase-script stricter about dirty working tree.
Otherwise the first commit rebase makes could include whatever
dirty state the original working tree had.

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-18 16:30:36 -07:00
Linus Torvalds
d571c2be99 [PATCH] git-applymbox: verify that index is clean
This makes git-applymbox verify that the index matches the current HEAD
before it starts applying patches.

Otherwise, you might have updated the index with unrelated changes, and
the first patch will commit not just the patch from the mbox, but also any
changes you had in your index.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-18 16:26:50 -07:00
Junio C Hamano
1bff6490b0 Link the glossary document from the main manual.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-18 15:52:58 -07:00
Junio C Hamano
d430042bcf Merge with master. 2005-08-18 15:46:07 -07:00
Junio C Hamano
66e06b6a17 Stupid typo fix for git rebase.
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-18 13:00:53 -07:00
Johannes Schindelin
2f5703c3a0 [PATCH] Updates to glossary
Changes to the descriptions of tree and tag objects, a link for ent, and
descriptions for rewind, rebase and core git were added.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-18 12:53:30 -07:00
Junio C Hamano
920b9d9256 Merge with master to pick up gitk --parents changes. 2005-08-18 12:25:18 -07:00
Junio C Hamano
9d34c29db3 Merge with gitk --parents change. 2005-08-18 12:18:27 -07:00
Junio C Hamano
0776f4cb34 Merge with master for gitk and doc updates. 2005-08-18 11:48:22 -07:00
Luck, Tony
accd952fd8 [PATCH] updates for Documentation/howto/using-topic-branches.txt
Small fix (use "git branch" to make branches, rather than "git checkout -b").

Optimization for trivial patches (apply to release and merge to test).

Three sample scripts appended.

Signed-off-by: Tony Luck <tony.luck@intel.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-18 10:26:06 -07:00
Johannes Schindelin
23bb8df2fb [PATCH] Add Makefile target glossary.html
This also includes a script which does the sorting, and introduces
hyperlinks for every described term.

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-18 10:25:52 -07:00
Paul Mackerras
e5ea701b8e Use the --parents flag to git-rev-list.
With --parents, git-rev-list gives us the list of parents on the
first line of each commit.  We use that rather than looking for
the parent: lines in the commit body, since this way we get to
know about the grafts for free.
2005-08-18 20:40:39 +10:00
Junio C Hamano
379955c696 Merge with gitk 2005-08-17 21:09:15 -07:00
Johannes Schindelin
f1671ecbfa [PATCH] Assorted changes to glossary
Based on the discussion on the git list, here are some important changes
to the glossary. (There is no cache, but an index. Use "object name"
rather than "SHA1". Reorder. Clarify.)

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 19:37:24 -07:00
Paul Mackerras
f6075ebadb Allow graph lines to jump through hyperspace.
When the graph gets too wide (as defined by the maxwidth variable,
which can be set in ~/.gitk), we can now terminate graph lines with
an arrow pointing downwards, and reintroduce them later with an
arrow pointing upwards when we need them.  This makes the graph much
less cluttered on large repositories such as the linux kernel.

Unfortunately this has made it slower; it takes about 10 seconds
user time on the linux-2.6 repository on my machine now, compared
to 6 seconds before.  I'll have to work on optimizing that.  Also
on the todo list are making the arrow heads active (so if you click
on them you jump to the other end) and improving the placement of
the null entry.
2005-08-18 09:30:10 +10:00
Junio C Hamano
942bc9c480 Merge from master for misc fixes. 2005-08-17 15:38:47 -07:00
Junio C Hamano
99a92f928f Make rebase script saner.
It did not check to see if the working tree was clean and matched
the commit we were starting out as, resulting in the initial rebased
commit including whatever dirty state the working tree has had.

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 15:19:57 -07:00
Junio C Hamano
0f87f89365 Make sure alternates are carried over from the original repository.
When we create a cheap local clone by pointing at the object databse
of the original repository, we forgot to take the alternates the original
repository might have had into account.

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 15:18:41 -07:00
Junio C Hamano
6a0049c076 Fix git-commit without paths.
The earlier one to grab output from diff-files --name-only has a grave
bug that when no paths are given it ended up doing the equivalent of
"git-commit --all", which was not what I intended.

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 15:17:03 -07:00
Linus Torvalds
cfb0af1d50 [PATCH] Make git-update-cache take relative pathnames
This also makes "./filename" acceptable as a side effect, since the
pathname normalization handles that too.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 14:53:40 -07:00
Linus Torvalds
828cc617c1 [PATCH] Export relative path handling "prefix_path()" function
Not all programs necessarily have a pathspec array of pathnames, some of
them (like git-update-cache) want to do things one file at a time.  So
export the single-path interface too.

Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 14:53:39 -07:00
Martin Langhoff
049f28c392 [PATCH] git-cvsimport - remove hardcoded reference to origin
... in the newly introduced merge detection code.

Signed-off-by: Martin Langhoff <martin.langhoff@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 14:53:39 -07:00
Martin Langhoff
db4b65821e [PATCH] Add merge detection to git-cvsimport
Added -m and -M flags for git-cvsimport to detect merge commits in cvs.
While this trusts the commit message, in repositories where merge commits
indicate 'merged from FOOBRANCH' the import works surprisingly well.

Even if some merges from CVS are bogus or incomplete, the resulting
branches are in better state to go forward (and merge) than without any
merge detection.

Signed-off-by: Martin Langhoff <martin.langhoff@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 14:53:39 -07:00
Junio C Hamano
ca08acca68 Merge changes from master. 2005-08-17 14:25:08 -07:00
Johannes Schindelin
da139813a7 [PATCH] Add GIT glossary
[jc: This is the version without asciidoc cross references;
Johannes says that the cross referenced one is generated from
this file using a Perl script, so I am placing this as the
source, and expecting to later receive the script and a Makefile
entry or two to massage this file into the final HTML or
whatever form.]

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 13:50:40 -07:00
Marco Costalba
f01c0fceef [PATCH] Let git-format-patch-script write on stdout
Avoid that git-format-patch writes out patch series
information on stderr when there are no errors

Signed-off-by: Marco Costalba <mcostalba@yahoo.it>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 12:13:12 -07:00
Kris Shannon
d5a8664ed5 [PATCH] Be consistent in naming of remote heads
The _remote_name variable used for messages does not need the
refs/heads/ prefix included.

Signed-off-by: Kris Shannon <kris.shannon@gmail.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 12:13:12 -07:00
Greg Louis
cdacb6208f [PATCH] use it's and its correctly in documentation
At one place in Documentation/tutorial.txt and several in the base
README, its was wrongly used in place of it's or vice versa.  One
instance remains somewhere in Documentation/howto/, which I didn't
correct because it's in a quotation.

Signed-off-by: Greg Louis <glouis@dynamicro.ca>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 12:13:12 -07:00
Johannes Schindelin
fbfd60d651 [PATCH] Also handle CVS branches with a '/' in their name
I track a CVS project which has a branch with a '/' in the branch name.
Since git wants the branch name to be a file name at the same time,
substitute that character to a '-' by default (override with "-s <subst>").
This should work well, despite the fact that a division and a difference
are completely different :-)

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 12:13:12 -07:00
Johannes Schindelin
35cc4bcd10 [PATCH] When copying or renaming, keep the mode, please
Without this patch, git-apply does not retain the mode when renaming or
copying files.

[jc: Good catch, Johannes.  I added a test case to demonstrate the
breackage in the original.]

Signed-off-by: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 12:13:12 -07:00
Kalle Valo
e4aec26f80 [PATCH] Change git-branch to list branches
If no argument provided to `git branch`, show available branches and
mark current branch with star.

This is based on patch written by Amos Waterland <apw@rossby.metr.ou.edu>.

[jc: and I changed it to handle subdirectories under refs/heads/ as well.]

Signed-off-by: Kalle Valo <Kalle.Valo@iki.fi>
Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 12:11:36 -07:00
Junio C Hamano
22cff6a5ab git-commit: pass explicit path to git-diff-files.
When running "git commit" with explicit path arguments, allow it to
take directory name.  This makes "git commit Documentation/" to commit
everything that is changed under Documentation/ directory.

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 12:11:36 -07:00
Junio C Hamano
86947d72d4 Pass options to underlying git-rev-list from show-branches.
This lets you say "git show-branches --max-count=30".

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 12:11:36 -07:00
Junio C Hamano
30b96fcef1 Add --symbolic flag to git-rev-parse.
This is most useful with --all, --revs-only, --no-flags and --verify.

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-17 12:11:36 -07:00
Paul Mackerras
244edd1241 Add graft support.
We read .git/info/grafts and use the information in there to
override the list of parents we get from git-rev-list or
git-cat-file.
2005-08-17 21:27:55 +10:00
Junio C Hamano
6680153441 Merge with master to get diff fixes. 2005-08-16 22:30:46 -07:00
Junio C Hamano
6bff6a6068 Teach applymbox to keep the Subject: line.
This corresponds to the -k flag to git format-patch --mbox
option.  The option should probably not be used when applying a
real e-mail patch, but is needed when format-patch and applymbox
pair is used for cherrypicking.

Signed-off-by: Junio C Hamano <junkio@cox.net>
2005-08-16 22:22:35 -07:00