9153983310
On Sun, 16 Apr 2006, Junio C Hamano wrote: > > In the mid-term, I am hoping we can drop the generate_header() > callchain _and_ the custom code that formats commit log in-core, > found in cmd_log_wc(). Ok, this was nastier than expected, just because the dependencies between the different log-printing stuff were absolutely _everywhere_, but here's a patch that does exactly that. The patch is not very easy to read, and the "--patch-with-stat" thing is still broken (it does not call the "show_log()" thing properly for merges). That's not a new bug. In the new world order it _should_ do something like if (rev->logopt) show_log(rev, rev->logopt, "---\n"); but it doesn't. I haven't looked at the --with-stat logic, so I left it alone. That said, this patch removes more lines than it adds, and in particular, the "cmd_log_wc()" loop is now a very clean: while ((commit = get_revision(rev)) != NULL) { log_tree_commit(rev, commit); free(commit->buffer); commit->buffer = NULL; } so it doesn't get much prettier than this. All the complexity is entirely hidden in log-tree.c, and any code that needs to flush the log literally just needs to do the "if (rev->logopt) show_log(...)" incantation. I had to make the combined_diff() logic take a "struct rev_info" instead of just a "struct diff_options", but that part is pretty clean. This does change "git whatchanged" from using "diff-tree" as the commit descriptor to "commit", and I changed one of the tests to reflect that new reality. Otherwise everything still passes, and my other tests look fine too. Signed-off-by: Linus Torvalds <torvalds@osdl.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
215 lines
5.1 KiB
C
215 lines
5.1 KiB
C
/*
|
|
* GIT - The information manager from hell
|
|
*
|
|
* Copyright (C) Linus Torvalds, 2005
|
|
*/
|
|
#include "cache.h"
|
|
#include "diff.h"
|
|
#include "commit.h"
|
|
#include "revision.h"
|
|
|
|
static const char diff_files_usage[] =
|
|
"git-diff-files [-q] [-0/-1/2/3 |-c|--cc] [<common diff options>] [<path>...]"
|
|
COMMON_DIFF_OPTIONS_HELP;
|
|
|
|
static struct rev_info rev;
|
|
static int silent = 0;
|
|
static int diff_unmerged_stage = 2;
|
|
static int combine_merges = 0;
|
|
static int dense_combined_merges = 0;
|
|
|
|
static void show_unmerge(const char *path)
|
|
{
|
|
diff_unmerge(&rev.diffopt, path);
|
|
}
|
|
|
|
static void show_file(int pfx, struct cache_entry *ce)
|
|
{
|
|
diff_addremove(&rev.diffopt, pfx, ntohl(ce->ce_mode),
|
|
ce->sha1, ce->name, NULL);
|
|
}
|
|
|
|
static void show_modified(int oldmode, int mode,
|
|
const unsigned char *old_sha1, const unsigned char *sha1,
|
|
char *path)
|
|
{
|
|
diff_change(&rev.diffopt, oldmode, mode, old_sha1, sha1, path, NULL);
|
|
}
|
|
|
|
int main(int argc, const char **argv)
|
|
{
|
|
const char **pathspec;
|
|
const char *prefix = setup_git_directory();
|
|
int entries, i;
|
|
|
|
git_config(git_diff_config);
|
|
diff_setup(&rev.diffopt);
|
|
while (1 < argc && argv[1][0] == '-') {
|
|
if (!strcmp(argv[1], "--")) {
|
|
argv++;
|
|
argc--;
|
|
break;
|
|
}
|
|
if (!strcmp(argv[1], "-0"))
|
|
diff_unmerged_stage = 0;
|
|
else if (!strcmp(argv[1], "-1"))
|
|
diff_unmerged_stage = 1;
|
|
else if (!strcmp(argv[1], "-2"))
|
|
diff_unmerged_stage = 2;
|
|
else if (!strcmp(argv[1], "-3"))
|
|
diff_unmerged_stage = 3;
|
|
else if (!strcmp(argv[1], "--base"))
|
|
diff_unmerged_stage = 1;
|
|
else if (!strcmp(argv[1], "--ours"))
|
|
diff_unmerged_stage = 2;
|
|
else if (!strcmp(argv[1], "--theirs"))
|
|
diff_unmerged_stage = 3;
|
|
else if (!strcmp(argv[1], "-q"))
|
|
silent = 1;
|
|
else if (!strcmp(argv[1], "-r"))
|
|
; /* no-op */
|
|
else if (!strcmp(argv[1], "-s"))
|
|
; /* no-op */
|
|
else if (!strcmp(argv[1], "-c"))
|
|
combine_merges = 1;
|
|
else if (!strcmp(argv[1], "--cc"))
|
|
dense_combined_merges = combine_merges = 1;
|
|
else {
|
|
int diff_opt_cnt;
|
|
diff_opt_cnt = diff_opt_parse(&rev.diffopt,
|
|
argv+1, argc-1);
|
|
if (diff_opt_cnt < 0)
|
|
usage(diff_files_usage);
|
|
else if (diff_opt_cnt) {
|
|
argv += diff_opt_cnt;
|
|
argc -= diff_opt_cnt;
|
|
continue;
|
|
}
|
|
else
|
|
usage(diff_files_usage);
|
|
}
|
|
argv++; argc--;
|
|
}
|
|
if (dense_combined_merges)
|
|
rev.diffopt.output_format = DIFF_FORMAT_PATCH;
|
|
|
|
/* Find the directory, and set up the pathspec */
|
|
pathspec = get_pathspec(prefix, argv + 1);
|
|
entries = read_cache();
|
|
|
|
if (diff_setup_done(&rev.diffopt) < 0)
|
|
usage(diff_files_usage);
|
|
|
|
/* At this point, if argc == 1, then we are doing everything.
|
|
* Otherwise argv[1] .. argv[argc-1] have the explicit paths.
|
|
*/
|
|
if (entries < 0) {
|
|
perror("read_cache");
|
|
exit(1);
|
|
}
|
|
|
|
for (i = 0; i < entries; i++) {
|
|
struct stat st;
|
|
unsigned int oldmode, newmode;
|
|
struct cache_entry *ce = active_cache[i];
|
|
int changed;
|
|
|
|
if (!ce_path_match(ce, pathspec))
|
|
continue;
|
|
|
|
if (ce_stage(ce)) {
|
|
struct {
|
|
struct combine_diff_path p;
|
|
struct combine_diff_parent filler[5];
|
|
} combine;
|
|
int num_compare_stages = 0;
|
|
|
|
combine.p.next = NULL;
|
|
combine.p.len = ce_namelen(ce);
|
|
combine.p.path = xmalloc(combine.p.len + 1);
|
|
memcpy(combine.p.path, ce->name, combine.p.len);
|
|
combine.p.path[combine.p.len] = 0;
|
|
combine.p.mode = 0;
|
|
memset(combine.p.sha1, 0, 20);
|
|
memset(&combine.p.parent[0], 0,
|
|
sizeof(combine.filler));
|
|
|
|
while (i < entries) {
|
|
struct cache_entry *nce = active_cache[i];
|
|
int stage;
|
|
|
|
if (strcmp(ce->name, nce->name))
|
|
break;
|
|
|
|
/* Stage #2 (ours) is the first parent,
|
|
* stage #3 (theirs) is the second.
|
|
*/
|
|
stage = ce_stage(nce);
|
|
if (2 <= stage) {
|
|
int mode = ntohl(nce->ce_mode);
|
|
num_compare_stages++;
|
|
memcpy(combine.p.parent[stage-2].sha1,
|
|
nce->sha1, 20);
|
|
combine.p.parent[stage-2].mode =
|
|
canon_mode(mode);
|
|
combine.p.parent[stage-2].status =
|
|
DIFF_STATUS_MODIFIED;
|
|
}
|
|
|
|
/* diff against the proper unmerged stage */
|
|
if (stage == diff_unmerged_stage)
|
|
ce = nce;
|
|
i++;
|
|
}
|
|
/*
|
|
* Compensate for loop update
|
|
*/
|
|
i--;
|
|
|
|
if (combine_merges && num_compare_stages == 2) {
|
|
show_combined_diff(&combine.p, 2,
|
|
dense_combined_merges,
|
|
&rev);
|
|
free(combine.p.path);
|
|
continue;
|
|
}
|
|
free(combine.p.path);
|
|
|
|
/*
|
|
* Show the diff for the 'ce' if we found the one
|
|
* from the desired stage.
|
|
*/
|
|
show_unmerge(ce->name);
|
|
if (ce_stage(ce) != diff_unmerged_stage)
|
|
continue;
|
|
}
|
|
|
|
if (lstat(ce->name, &st) < 0) {
|
|
if (errno != ENOENT && errno != ENOTDIR) {
|
|
perror(ce->name);
|
|
continue;
|
|
}
|
|
if (silent)
|
|
continue;
|
|
show_file('-', ce);
|
|
continue;
|
|
}
|
|
changed = ce_match_stat(ce, &st, 0);
|
|
if (!changed && !rev.diffopt.find_copies_harder)
|
|
continue;
|
|
oldmode = ntohl(ce->ce_mode);
|
|
|
|
newmode = canon_mode(st.st_mode);
|
|
if (!trust_executable_bit &&
|
|
S_ISREG(newmode) && S_ISREG(oldmode) &&
|
|
((newmode ^ oldmode) == 0111))
|
|
newmode = oldmode;
|
|
show_modified(oldmode, newmode,
|
|
ce->sha1, (changed ? null_sha1 : ce->sha1),
|
|
ce->name);
|
|
}
|
|
diffcore_std(&rev.diffopt);
|
|
diff_flush(&rev.diffopt);
|
|
return 0;
|
|
}
|