Jeff King 2805bb5970 fetch: replace static buffer with xstrfmt ... We parse the INFINITE_DEPTH constant into a static, fixed-size buffer using sprintf. This buffer is sufficiently large for the current constant, but it's a suspicious pattern, as the constant is defined far away, and it's not immediately obvious that 12 bytes are large enough to hold it. We can just use xstrfmt here, which gets rid of any question of the buffer size. It also removes any concerns with object lifetime, which means we do not have to wonder why this buffer deep within a conditional is marked "static" (we never free our newly allocated result, of course, but that's OK; it's global that lasts the lifetime of the whole program anyway). Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>		2015-09-25 10:18:18 -07:00
..
add.c	Merge branch 'sb/remove-unused-var-from-builtin-add' into maint	2015-08-19 14:41:33 -07:00
am.c	Merge branch 'jc/builtin-am-signoff-regression-fix'	2015-09-08 15:35:05 -07:00
annotate.c	annotate: use argv_array	2014-07-16 11:10:11 -07:00
apply.c	replace trivial malloc + sprintf / strcpy calls with xstrfmt	2015-09-25 10:18:18 -07:00
archive.c
bisect--helper.c
blame.c	memoize common git-path "constant" files	2015-08-10 15:37:14 -07:00
branch.c	write_file(): drop "fatal" parameter	2015-08-24 13:09:02 -07:00
bundle.c
cat-file.c
check-attr.c
check-ignore.c
check-mailmap.c
check-ref-format.c
checkout-index.c
checkout.c	Merge branch 'jc/calloc-pathspec' into maint	2015-09-03 19:18:00 -07:00
clean.c
clone.c	Merge branch 'jk/guess-repo-name-regression-fix' into maint	2015-08-25 16:09:17 -07:00
column.c
commit-tree.c
commit.c	Merge branch 'dt/commit-preserve-base-index-upon-opportunistic-cache-tree-update'	2015-09-01 16:31:29 -07:00
config.c	config: use xstrfmt in normalize_value	2015-09-25 10:18:18 -07:00
count-objects.c
credential.c
describe.c	Merge branch 'sg/describe-contains'	2015-08-31 15:39:10 -07:00
diff-files.c
diff-index.c
diff-tree.c
diff.c
fast-export.c
fetch-pack.c
fetch.c	fetch: replace static buffer with xstrfmt	2015-09-25 10:18:18 -07:00
fmt-merge-msg.c
for-each-ref.c
fsck.c	fsck: use strbuf to generate alternate directories	2015-09-25 10:18:18 -07:00
gc.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
get-tar-commit-id.c
grep.c
hash-object.c
help.c	Merge branch 'sb/leaks'	2015-03-20 13:11:53 -07:00
index-pack.c	use xsnprintf for generating git object headers	2015-09-25 10:18:18 -07:00
init-db.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
interpret-trailers.c
log.c	builtin/log.c: minor reformat	2015-08-25 13:11:21 -07:00
ls-files.c	ps_matched: xcalloc() takes nmemb and then element size	2015-08-20 09:57:38 -07:00
ls-remote.c	replace trivial malloc + sprintf / strcpy calls with xstrfmt	2015-09-25 10:18:18 -07:00
ls-tree.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
mailinfo.c
mailsplit.c	mailsplit: make PATH_MAX buffers dynamic	2015-09-25 10:18:18 -07:00
merge-base.c
merge-file.c
merge-index.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
merge-ours.c
merge-recursive.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
merge-tree.c	merge-tree: remove unused df_conflict arguments	2014-09-02 11:02:58 -07:00
merge.c	memoize common git-path "constant" files	2015-08-10 15:37:14 -07:00
mktag.c
mktree.c
mv.c
name-rev.c	replace trivial malloc + sprintf / strcpy calls with xstrfmt	2015-09-25 10:18:18 -07:00
notes.c	Merge branch 'jk/notes-merge-config'	2015-08-31 15:39:05 -07:00
pack-objects.c	Merge branch 'ah/pack-objects-usage-strings'	2015-09-01 16:31:12 -07:00
pack-redundant.c
pack-refs.c
patch-id.c
prune-packed.c
prune.c
pull.c	pull: don't mark values for option "rebase" for translation	2015-09-11 09:50:00 -07:00
push.c	push: add a config option push.gpgSign for default signed pushes	2015-08-19 12:58:58 -07:00
read-tree.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
receive-pack.c	receive-pack: convert strncpy to xsnprintf	2015-09-25 10:18:18 -07:00
reflog.c	Merge branch 'ah/reflog-typofix-in-error'	2015-09-01 16:31:18 -07:00
remote-ext.c
remote-fd.c
remote.c	remote.c: drop extraneous local variable from migrate_file	2015-08-10 15:37:12 -07:00
repack.c	prefer mkpathdup to mkpath in assignments	2015-08-10 15:37:12 -07:00
replace.c
rerere.c	rerere: release lockfile in non-writing functions	2015-09-01 15:52:54 -07:00
reset.c	memoize common git-path "constant" files	2015-08-10 15:37:14 -07:00
rev-list.c	rev-list: make it obvious that we do not support notes	2015-08-24 10:33:15 -07:00
rev-parse.c
revert.c
rm.c
send-pack.c	push: add a config option push.gpgSign for default signed pushes	2015-08-19 12:58:58 -07:00
shortlog.c
show-branch.c	show-branch: avoid segfault with --reflog of unborn branch	2015-09-25 10:18:18 -07:00
show-ref.c	show-ref: place angle brackets around variables in usage string	2015-08-31 09:33:53 -07:00
stripspace.c
symbolic-ref.c
tag.c	tag, update-ref: improve description of option "create-reflog"	2015-09-11 09:50:02 -07:00
unpack-file.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
unpack-objects.c
update-index.c
update-ref.c	tag, update-ref: improve description of option "create-reflog"	2015-09-11 09:50:02 -07:00
update-server-info.c
upload-archive.c
var.c
verify-commit.c
verify-pack.c
verify-tag.c
worktree.c	Merge branch 'jc/am-state-fix'	2015-08-31 15:39:03 -07:00
write-tree.c