Jeff King 3ec832c4b5 config: use xstrfmt in normalize_value ... We xmalloc a fixed-size buffer and sprintf into it; this is OK because the size of our formatting types is finite, but that's not immediately clear to a reader auditing sprintf calls. Let's switch to xstrfmt, which is shorter and obviously correct. Note that just dropping the common xmalloc here causes gcc to complain with -Wmaybe-uninitialized. That's because if "types" does not match any of our known types, we never write anything into the "normalized" pointer. With the current code, gcc doesn't notice because we always return a valid pointer (just one which might point to uninitialized data, but the compiler doesn't know that). In other words, the current code is potentially buggy if new types are added without updating this spot. So let's take this opportunity to clean up the function a bit more. We can drop the "normalized" pointer entirely, and just return directly from each code path. And then add an assertion at the end in case we haven't covered any cases. Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>		2015-09-25 10:18:18 -07:00
..
add.c	Merge branch 'sb/remove-unused-var-from-builtin-add' into maint	2015-08-19 14:41:33 -07:00
am.c	Merge branch 'jc/builtin-am-signoff-regression-fix'	2015-09-08 15:35:05 -07:00
annotate.c
apply.c	replace trivial malloc + sprintf / strcpy calls with xstrfmt	2015-09-25 10:18:18 -07:00
archive.c
bisect--helper.c
blame.c	memoize common git-path "constant" files	2015-08-10 15:37:14 -07:00
branch.c	write_file(): drop "fatal" parameter	2015-08-24 13:09:02 -07:00
bundle.c
cat-file.c
check-attr.c
check-ignore.c
check-mailmap.c
check-ref-format.c
checkout-index.c
checkout.c	Merge branch 'jc/calloc-pathspec' into maint	2015-09-03 19:18:00 -07:00
clean.c
clone.c	Merge branch 'jk/git-path'	2015-08-19 14:48:56 -07:00
column.c
commit-tree.c
commit.c	Merge branch 'dt/commit-preserve-base-index-upon-opportunistic-cache-tree-update'	2015-09-01 16:31:29 -07:00
config.c	config: use xstrfmt in normalize_value	2015-09-25 10:18:18 -07:00
count-objects.c
credential.c
describe.c	Merge branch 'sg/describe-contains'	2015-08-31 15:39:10 -07:00
diff-files.c
diff-index.c
diff-tree.c
diff.c
fast-export.c
fetch-pack.c
fetch.c	Merge branch 'mh/get-remote-group-fix' into maint	2015-09-03 19:17:48 -07:00
fmt-merge-msg.c
for-each-ref.c
fsck.c	fsck: use strbuf to generate alternate directories	2015-09-25 10:18:18 -07:00
gc.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
get-tar-commit-id.c
grep.c	Merge branch 'ps/grep-help-all-callback-arg'	2015-04-20 15:28:34 -07:00
hash-object.c
help.c
index-pack.c	use xsnprintf for generating git object headers	2015-09-25 10:18:18 -07:00
init-db.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
interpret-trailers.c
log.c	builtin/log.c: minor reformat	2015-08-25 13:11:21 -07:00
ls-files.c	ps_matched: xcalloc() takes nmemb and then element size	2015-08-20 09:57:38 -07:00
ls-remote.c	replace trivial malloc + sprintf / strcpy calls with xstrfmt	2015-09-25 10:18:18 -07:00
ls-tree.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
mailinfo.c
mailsplit.c	mailsplit: make PATH_MAX buffers dynamic	2015-09-25 10:18:18 -07:00
merge-base.c
merge-file.c
merge-index.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
merge-ours.c	Move 'builtin-*' into a 'builtin/' subdirectory	2010-02-22 14:29:41 -08:00
merge-recursive.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
merge-tree.c
merge.c
mktag.c
mktree.c
mv.c
name-rev.c	replace trivial malloc + sprintf / strcpy calls with xstrfmt	2015-09-25 10:18:18 -07:00
notes.c	Merge branch 'jk/notes-merge-config'	2015-08-31 15:39:05 -07:00
pack-objects.c	Merge branch 'ah/pack-objects-usage-strings'	2015-09-01 16:31:12 -07:00
pack-redundant.c
pack-refs.c
patch-id.c
prune-packed.c
prune.c
pull.c	pull: don't mark values for option "rebase" for translation	2015-09-11 09:50:00 -07:00
push.c	push: add a config option push.gpgSign for default signed pushes	2015-08-19 12:58:58 -07:00
read-tree.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
receive-pack.c	receive-pack: convert strncpy to xsnprintf	2015-09-25 10:18:18 -07:00
reflog.c	Merge branch 'ah/reflog-typofix-in-error'	2015-09-01 16:31:18 -07:00
remote-ext.c
remote-fd.c	Fix sparse warnings	2011-03-22 10:16:54 -07:00
remote.c
repack.c
replace.c
rerere.c	rerere: release lockfile in non-writing functions	2015-09-01 15:52:54 -07:00
reset.c
rev-list.c	rev-list: make it obvious that we do not support notes	2015-08-24 10:33:15 -07:00
rev-parse.c
revert.c
rm.c
send-pack.c	push: add a config option push.gpgSign for default signed pushes	2015-08-19 12:58:58 -07:00
shortlog.c
show-branch.c	show-branch: avoid segfault with --reflog of unborn branch	2015-09-25 10:18:18 -07:00
show-ref.c	show-ref: place angle brackets around variables in usage string	2015-08-31 09:33:53 -07:00
stripspace.c
symbolic-ref.c
tag.c	tag, update-ref: improve description of option "create-reflog"	2015-09-11 09:50:02 -07:00
unpack-file.c	convert trivial sprintf / strcpy calls to xsnprintf	2015-09-25 10:18:18 -07:00
unpack-objects.c
update-index.c
update-ref.c	tag, update-ref: improve description of option "create-reflog"	2015-09-11 09:50:02 -07:00
update-server-info.c
upload-archive.c
var.c
verify-commit.c
verify-pack.c
verify-tag.c
worktree.c	Merge branch 'jc/am-state-fix'	2015-08-31 15:39:03 -07:00
write-tree.c